Fixing strange iOS7 bug with Math.abs on non-primitive numbers.

(Issue andrewplummer#400)
Web5design · Dec 12, 2013 · 11fa382 · 11fa382
1 parent cd425e1
commit 11fa382
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ v1.4.2
 - Bower.json now points to unminified script (#388)
 - Date.create(null) is now interpeted as a time stamp (#387)
 - Fix for ambiguous years not working with `Date#past/future` (#383)
+- Fix for odd iOS7 bug with `Number#abs` (#400)
 
 v1.4.1
 ======

diff --git a/lib/number.js b/lib/number.js
@@ -390,7 +390,11 @@
     });
     extendSimilar(number, true, true, 'abs,pow,sin,asin,cos,acos,tan,atan,exp,pow,sqrt', function(methods, name) {
       methods[name] = function(a, b) {
-        return math[name](this, a, b);
+        // Note that .valueOf() here is only required due to a
+        // very strange bug in iOS7 that only occurs occasionally
+        // in which Math.abs() called on non-primitive numbers
+        // returns a completely different number (Issue #400)
+        return math[name](this.valueOf(), a, b);
       }
     });
   }