code refactoring #2

WebDollar · Dec 24, 2019 · 5a73e72 · 5a73e72
1 parent ae7fc2e
commit 5a73e72
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/...on/blockchain/interface-blockchain/blocks/Interface-Blockchain-Block-Data-Transactions.js b/...on/blockchain/interface-blockchain/blocks/Interface-Blockchain-Block-Data-Transactions.js
@@ -85,9 +85,9 @@ class InterfaceBlockchainBlockDataTransactions {
 
         for (let i=0; i<this.transactions.length; i++) {
 
-            if (typeof blockValidationType === 'undefined') {
+            if (  !blockValidationType )
                 blockValidationType = {};
-            }
+
 
             blockValidationType['take-transactions-list-in-consideration'] = {
                 validation  : true,
@@ -199,14 +199,14 @@ class InterfaceBlockchainBlockDataTransactions {
         return offset;
     }
 
-    _processBlockDataTransaction(blockHeight, transaction, multiplicationFactor = 1 , minerAddress = undefined, revertActions = undefined, showUpdate) {
+    _processBlockDataTransaction(blockHeight, transaction, multiplicationFactor = 1 , minerAddress , revertActions , showUpdate) {
 
         //skipping checking the Transaction in case it requires reverting
-        if (multiplicationFactor === 1) {
-            if (!transaction.validateTransactionOnce(blockHeight)) {
+        if (multiplicationFactor === 1)
+            if (!transaction.validateTransactionOnce(blockHeight))
                 throw {message: 'couldn\'t process the transaction ', transaction: transaction.txId };
-            }
-        }
+
+
 
         transaction.processTransaction(multiplicationFactor, minerAddress, revertActions, showUpdate);
 

diff --git a/...on/blockchain/interface-blockchain/transactions/protocol/Transactions-Download-Manager.js b/...on/blockchain/interface-blockchain/transactions/protocol/Transactions-Download-Manager.js
@@ -129,7 +129,7 @@ class TransactionsDownloadManager{
                     if( this._transactionsQueue[txId].fails <= 2 ){
 
                         //Check if tx has socket and is still valid
-                        if ( this._transactionsQueue[txId].socket !== undefined )
+                        if ( this._transactionsQueue[txId].socket )
                             return {id:txId };
                         else
                             this.removeTransaction(txId);

diff --git a/src/common/mining-pools/pool/pool-management/Pool-Management.js b/src/common/mining-pools/pool/pool-management/Pool-Management.js
@@ -129,7 +129,7 @@ class PoolManagement{
 
                 await Blockchain.MinerPoolManagement.setMinerPoolStarted(false);
 
-                if (Blockchain.ServerPoolManagement !== undefined)
+                if (Blockchain.ServerPoolManagement)
                     await Blockchain.ServerPoolManagement.setServerPoolStarted(false);
 
             }

diff --git a/src/node/webrtc/web-peer/node-web-peer-webRTC.js b/src/node/webrtc/web-peer/node-web-peer-webRTC.js
@@ -200,7 +200,7 @@ class NodeWebPeerRTC {
 
                             },
                             (error) => {
-                                resolve({result:false, message: "Generating Initiator - Error Setting Local Description " +(error !== undefined ? error.toString() : '')});
+                                resolve({result:false, message: "Generating Initiator - Error Setting Local Description " +(error ? error.toString() : '')});
                                 console.error("Generating Initiator - Error Setting Local Description ", error);
                             }
                         );
@@ -350,7 +350,7 @@ class NodeWebPeerRTC {
 
         this.peer.oniceconnectionstatechange = function() {
 
-            if (this.peer !== undefined && this.peer.iceConnectionState === 'disconnected') {
+            if (this.peer && this.peer.iceConnectionState === 'disconnected') {
 
                 console.log('iceConnection Disconnected');
                 if (this.peer.connected === true) {
@@ -399,7 +399,7 @@ class NodeWebPeerRTC {
                         done = true;
 
                         for (let i=0; i < chunks; i++)
-                            if (message.chunks[i] === undefined){
+                            if ( !message.chunks[i] ){
                                 done = false;
                                 break;
                             }