Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phg/number string query param #1142

Merged
merged 19 commits into from
Dec 26, 2024
Merged

Phg/number string query param #1142

merged 19 commits into from
Dec 26, 2024

Conversation

Pgarrett
Copy link
Collaborator

@Pgarrett Pgarrett commented Dec 9, 2024

What's in the box:

  • When using nameWithQueryParameters option, empty strings and negative number query parameters are also added to the name.
  • Instead of performing one disambiguation: path or query parameters, it will perform any that apply. The idea behind it is that system tests often require more characteristics to differentiate names, since they're executing several features/topics at the same time.

@Pgarrett Pgarrett marked this pull request as ready for review December 9, 2024 12:23
@Pgarrett Pgarrett requested a review from arcuri82 December 9, 2024 12:24
@Pgarrett Pgarrett requested a review from arcuri82 December 20, 2024 11:39
@Pgarrett Pgarrett requested a review from arcuri82 December 23, 2024 14:47
@arcuri82 arcuri82 merged commit 94025d4 into master Dec 26, 2024
14 checks passed
@Pgarrett Pgarrett deleted the phg/numberStringQueryParam branch December 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants