Only delete old-format bank if save succeeded

WesMena · Nov 14, 2019 · d59176d · d59176d
1 parent aa106d8
commit d59176d
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/3ds/source/Bank.cpp b/3ds/source/Bank.cpp
@@ -361,7 +361,6 @@ bool Bank::hasChanged() const
 
 void Bank::convertFromBankBin()
 {
-    bool deleteOld = true;
     Gui::waitFrame(i18n::localize("BANK_CONVERT"));
     FSStream stream(Archive::sd(), "/3ds/PKSM/bank/bank.bin", FS_OPEN_READ);
     size_t oldSize = stream.size();
@@ -442,11 +441,10 @@ void Bank::convertFromBankBin()
 
     delete[] oldData;
 
-    if (deleteOld)
+    if (save())
     {
         Archive::deleteFile(Archive::sd(), u"/3ds/PKSM/bank/bank.bin");
     }
-    save();
 }
 
 const std::string& Bank::name() const