Cookie | Properly remove secure cookie check salt

Wisembly · May 18, 2018 · de2e488 · de2e488
1 parent 52bb885
commit de2e488
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/build/basil.js b/build/basil.js
@@ -205,7 +205,9 @@
 				// if cookie secure activated, ensure it works (not the case if we are in http only)
 				if (options && options.secure) {
 					this.set(_salt, _salt, options);
-					return this.get(_salt) === _salt;
+					var hasSecurelyPersited = this.get(_salt) === _salt;
+					this.remove(_salt);
+					return hasSecurelyPersited;
 				}
 				return true;
 			},

diff --git a/build/basil.min.js b/build/basil.min.js
diff --git a/src/basil.js b/src/basil.js
@@ -205,7 +205,9 @@
 				// if cookie secure activated, ensure it works (not the case if we are in http only)
 				if (options && options.secure) {
 					this.set(_salt, _salt, options);
-					return this.get(_salt) === _salt;
+					var hasSecurelyPersited = this.get(_salt) === _salt;
+					this.remove(_salt);
+					return hasSecurelyPersited;
 				}
 				return true;
 			},