Fix variable speeds when having different FPS #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wolkenfarmer
approved these changes
Mar 13, 2021
Comment on lines
-11
to
+15
| public float Speed; | ||
| public int Health { get; private set; } | ||
| public int Shield { get; private set; } | ||
| public int Damage { get; private set; } | ||
|
|
||
| int pHealth; | ||
| int pShield; | ||
| int pDamage; | ||
|
|
||
| public int Health | ||
| { | ||
| get { return pHealth; } | ||
| } | ||
| public int Shield | ||
| { | ||
| get { return pShield; } | ||
| } | ||
| public int Damage | ||
| { | ||
| get { return pDamage; } | ||
| } | ||
| public float Speed { get; private set; } |
There was a problem hiding this comment.
Nice change, much simple
superb
Comment on lines
-78
to
+69
| public void setShield(int newShield) { pShield = newShield; } | ||
| public void setHealth(int newHealth) { pHealth = newHealth; } | ||
| public void setDamage(int newDamage) { pDamage = newDamage; } | ||
| public void setShield(int newShield) { Shield = newShield; } | ||
| public void setHealth(int newHealth) { Health = newHealth; } | ||
| public void setDamage(int newDamage) { Damage = newDamage; } | ||
|
|
||
| public void setSpeed(float newSpeed) { Speed = newSpeed; } |
There was a problem hiding this comment.
wow, now I actually understand what's going on here.
This pHealth etc was sus to me anyway
There was a problem hiding this comment.
I am very honestly wondering why I didn't remove those functions - you can set the variables by assigning them directly...
Woops, i missed the private modifier.
| @@ -39,7 +26,7 @@ protected virtual void Update() | |||
|
|
|||
| public void Move(float h, float v) | |||
| { | |||
| gameObject.transform.position += new Vector3(h * Speed, v * Speed); | |||
| gameObject.transform.position += new Vector3(h * Speed * Time.deltaTime, v * Speed * Time.deltaTime); | |||
There was a problem hiding this comment.
of course 🤦
Easy but important addition, very good!
| setHealth(2000); | ||
| setDamage(150); | ||
| setSpeed(20); |
There was a problem hiding this comment.
More individual, much good
superb
Comment on lines
+33
to
+47
| // Objects have to be initialized first so we can get their speed | ||
| if (firstTick) | ||
| { | ||
| foreach (var obj in objects) | ||
| { | ||
| obj.transform.parent = group.transform; | ||
| var enemyScript = obj.GetComponent<Enemyship>(); | ||
| enemyScript.SetPartOfUnit(this); | ||
|
|
||
| if (enemyScript.Speed < speed) | ||
| speed = enemyScript.Speed; | ||
| } | ||
| firstTick = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
because the components may have not been initialized yet, at least that's the reason I remember.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a bit of cleanup.
My following PRs will depend on this one.