Merge pull request DefinitelyTyped#2393 from bolhovsky/custom-bindings

Extend custom bindings API definition
Wordenskjold · Jul 10, 2014 · 20e2817 · 20e2817
2 parents a87641d + d1db936
commit 20e2817
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/knockout/knockout.d.ts b/knockout/knockout.d.ts
@@ -127,12 +127,13 @@ interface KnockoutBindingContext {
 
 interface KnockoutAllBindingsAccessor {
     (): any;
-    get(bindingName: string): any;
+    get(name: string): any;
+    has(name: string): boolean;
 }
 
 interface KnockoutBindingHandler {
-    init?(element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext): void;
-    update?(element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext): void;
+    init? (element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext): void;
+    update? (element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext): void;
     options?: any;
 }
 

diff --git a/knockout/tests/knockout-tests.ts b/knockout/tests/knockout-tests.ts
@@ -591,11 +591,15 @@ function test_allBindingsAccessor() {
     ko.bindingHandlers.allBindingsAccessorTest = {
         init: (element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext) => {
             var allBindings = allBindingsAccessor();
+            var hasBinding = allBindingsAccessor.has("myBindingName");
             var myBinding = allBindingsAccessor.get("myBindingName");
+            var fnAccessorBinding = allBindingsAccessor().myBindingName;
         },
         update: (element: any, valueAccessor: () => any, allBindingsAccessor: KnockoutAllBindingsAccessor, viewModel: any, bindingContext: KnockoutBindingContext) => {
             var allBindings = allBindingsAccessor();
+            var hasBinding = allBindingsAccessor.has("myBindingName");
             var myBinding = allBindingsAccessor.get("myBindingName");
+            var fnAccessorBinding = allBindingsAccessor().myBindingName;
         }
     };
 }