Skip to content

Commit

Permalink
extra fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
pavjacko committed Sep 30, 2019
1 parent b0e6b2a commit 72012fe
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 9 deletions.
7 changes: 4 additions & 3 deletions docs/DOC_INTEGRATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@ title: Integrations
sidebar_label: Integrations
---

# Documentation for ReNative Integrations

---

<img src="https://renative.org/img/ic_integrations.png" width=50 height=50 />

## Integrations

TODO

## Docker

https://www.npmjs.com/package/@rnv/deploy-docker

## FTP

TODO
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"react-native-web-image-loader": "0.0.5",
"react-navigation": "3.9.2",
"react-navigation-tabs": "2.0.0-alpha.0",
"renative": "file:./packages/renative"
"renative": "file:./packages/renative",
"@rnv/deploy-docker": "latest"
},
"devDependencies": {
"concurrently": "4.1.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/rnv/src/platformTools/web/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
logSuccess,
waitForWebpack,
logError,
logWarning,
getAppTitle
} from '../../common';
import { copyBuildsFolder, copyAssetsFolder } from '../../projectTools/projectParser';
Expand Down Expand Up @@ -163,7 +164,7 @@ const runWeb = (c, platform, port) => new Promise((resolve, reject) => {
.then(() => resolve())
.catch(e => reject(e));
} else {
logInfo(
logWarning(
`Looks like your ${chalk.white(platform)} devServerHost at port ${chalk.white(
port
)} is already running. ReNative Will use it!`
Expand Down
8 changes: 6 additions & 2 deletions packages/rnv/src/projectTools/buildHooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ const rnvHooksRun = c => new Promise((resolve, reject) => {

buildHooks(c)
.then(() => {
if (c.buildHooks[c.program.exeMethod]) {
c.buildHooks[c.program.exeMethod](c)
if (!c.buildHooks) {
reject('Build hooks have not been compiled properly!');
return;
}
if (c.buildHooks[c.program?.exeMethod]) {
c.buildHooks[c.program?.exeMethod](c)
.then(() => resolve())
.catch(e => reject(e));
} else {
Expand Down
4 changes: 2 additions & 2 deletions packages/rnv/src/systemTools/exec.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ const _execute = (c, command, opts = {}) => {
}

return child.then((res) => {
spinner && child.stdout.off('data', printLastLine);
spinner && child.stdout.off && child.stdout.off('data', printLastLine);
!silent && !mono && spinner.succeed(`Executing: ${logMessage}`);
logDebug(res.all);
interval && clearInterval(interval);
// logDebug(res);
return res.stdout;
}).catch((err) => {
spinner && child.stdout.off('data', printLastLine);
spinner && child.stdout.off && child.stdout.off('data', printLastLine);
if (!silent && !mono && !ignoreErrors) spinner.fail(`FAILED: ${logMessage}`); // parseErrorMessage will return false if nothing is found, default to previous implementation
logDebug(err.all);
interval && clearInterval(interval);
Expand Down

0 comments on commit 72012fe

Please sign in to comment.