Skip to content

Commit

Permalink
[cloud_firestore] Fix test that used FirebaseApp.channel (firebase#1476)
Browse files Browse the repository at this point in the history
* [cloud_firestore] Fix test that used FirebaseApp.channel

* dartfmt

* bump version
  • Loading branch information
Harry Terkelsen authored Nov 21, 2019
1 parent 8bf9b22 commit 503614f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/cloud_firestore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.12.10+3

* Fixed test that used `FirebaseApp.channel`.

## 0.12.10+2

* Fixed analyzer warnings about unused fields.
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_firestore/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database
live synchronization and offline support on Android and iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_firestore
version: 0.12.10+2
version: 0.12.10+3

flutter:
plugin:
Expand Down
5 changes: 4 additions & 1 deletion packages/cloud_firestore/test/cloud_firestore_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@ void main() {
"hasPendingWrites": false,
"isFromCache": false,
};
const MethodChannel firebaseCoreChannel =
MethodChannel('plugins.flutter.io/firebase_core');

setUp(() async {
mockHandleId = 0;
// Required for FirebaseApp.configure
FirebaseApp.channel.setMockMethodCallHandler(
firebaseCoreChannel.setMockMethodCallHandler(
(MethodCall methodCall) async {},
);
app = await FirebaseApp.configure(
Expand Down

0 comments on commit 503614f

Please sign in to comment.