Skip to content

Commit

Permalink
Add back default latest tag for pulling image (apache#26121)
Browse files Browse the repository at this point in the history
The `pull` commands of Breeze ci-image and prod-image got the
possibility of pulling latest image in apache#26086 but the --image-tag
remained as required. This PR brings back the --image-tag to fall
back to 'latest' for pull commands.
  • Loading branch information
potiuk authored Sep 1, 2022
1 parent 4dd628c commit a1e7f94
Show file tree
Hide file tree
Showing 14 changed files with 1,108 additions and 1,081 deletions.
9 changes: 8 additions & 1 deletion dev/breeze/src/airflow_breeze/utils/common_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,25 +185,32 @@
'-t',
'--image-tag',
help='Tag of the image which is used to pull the image',
show_default=True,
default="latest",
envvar='IMAGE_TAG',
required=True,
)
option_image_tag_for_building = click.option(
'-t',
'--image-tag',
help='Tag the image after building it',
show_default=True,
default="latest",
envvar='IMAGE_TAG',
)
option_image_tag_for_running = click.option(
'-t',
'--image-tag',
help='Tag of the image which is used to run the image (implies --mount-sources=skip)',
show_default=True,
default="latest",
envvar='IMAGE_TAG',
)
option_image_tag_for_verifying = click.option(
'-t',
'--image-tag',
help='Tag of the image when verifying it',
show_default=True,
default="latest",
envvar='IMAGE_TAG',
)
option_image_name = click.option(
Expand Down
32 changes: 16 additions & 16 deletions images/breeze/output-commands-hash.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,35 @@ ci:get-workflow-info:01ee34c33ad62fa5dc33e0ac8773223f
ci:resource-check:0fb929ac3496dbbe97acfe99e35accd7
ci:selective-check:d4e3c250cd6f2b0040fbe6557fa423f6
ci:31566cdcdde216086f559215223b2378
ci-image:build:f2c38a416078b4ff6967d7857d7dbdcc
ci-image:pull:ffaa87e22fc22a7880f17ca459f80b59
ci-image:verify:4ccbe2011b613926d7d194a05699ec6b
ci-image:1ff737961d2764ba0cc45e87179a564e
ci-image:build:89db1d6919463181d3bd182717488ef5
ci-image:pull:8aca8679e6030ad0d6e59216af40c0b3
ci-image:verify:a2daeaa820c0baca31da2737929b38b9
ci-image:7dcc7fd3a5e5e8867d83a36c72233b45
cleanup:9bf46a1dfd9db4fe13a1c233ad1bb96b
compile-www-assets:23675c1862d0968cbff6ab6f1d93d488
exec:89b81bc34d45b0fe6653a6db5482258c
prod-image:build:dcae8f9dd287b9efa9572ace17ccd5d7
prod-image:pull:a434a9bb39a845d3413f050d908c52fd
prod-image:verify:708b5b6e4aebcd69cd46f6d8d353fcd0
prod-image:b3a6629fd772d96aa0f5e75d551b3179
release-management:generate-constraints:353012827a7069e45cd80cb33e37b921
prod-image:build:48bac19249618ed279732b0574a7575c
prod-image:pull:1aef99d8fd0706c7666170949d7ba834
prod-image:verify:c9242a00b49e0081f34a19420e8032f5
prod-image:996628f39fd4459bc600509084034a49
release-management:generate-constraints:48d2de2aa34bcbaacdef9ac92ec1bab7
release-management:prepare-airflow-package:cff9d88ca313db10f3cc464c6798f6be
release-management:prepare-provider-documentation:3ac547738c671e460523b5c01e295988
release-management:prepare-provider-packages:89502ebc78a68f15f4fffaf118b9c68f
release-management:release-prod-images:8858fe5a13989c7c65a79dc97a880928
release-management:verify-provider-packages:797e60067fc4611112527de808b5c1c1
release-management:9382c1e2581f30acdc0289de55c6d187
release-management:b633b97e7912daa45259555f3b407e63
setup:autocomplete:9787fd9ac963e3c29e54ac53ec2b9565
setup:config:92653afc11889e1b78e3a2e38f41107f
setup:regenerate-command-images:072427bef0d0774f8cc135314d649315
setup:self-upgrade:d02f70c7a230eae3463ceec2056b63fa
setup:version:d11da4c17a23179830079b646160149c
setup:5808681875b6b8c9bb0cb026b280c408
shell:2dc8c9d6328897c7b3fcb5d505a893a9
start-airflow:3e793b11dc2158c54bfc189bfe20d6f2
shell:c24408a5fa0dc8e5405449d02ad88e29
start-airflow:17b93add6c8ea218e9e5f0e0360d59ac
static-checks:30c7b614c69fd3ec712db8e3fa57c3da
stop:8ebd8a42f1003495d37b884de5ac7ce6
testing:docker-compose-tests:8ae3b6211fd31db81a750d1c6b96ec3d
testing:helm-tests:fa8fb6376ead71125103972b73de6b93
testing:tests:3b6d070acc10c2091a8c817f6421f9c2
testing:094ea307ed553e89853bc31b976bf20e
testing:docker-compose-tests:3e07be65e30219930d3c62a593dd8c6a
testing:helm-tests:66894434df46efe2f51bcb6dd168992d
testing:tests:32deda30f3899e8ae6e241238f990d68
testing:325509289c9e2880e390a8cef687ac90
Loading

0 comments on commit a1e7f94

Please sign in to comment.