Skip to content

Commit

Permalink
Allows mounting local sources for github run-id images (apache#12650)
Browse files Browse the repository at this point in the history
The images that are build on github can be used to reproduce
the test errors in CI - they should then be mounted without
local sources. However in some cases when you are dealing with
dependencies for example, it is useful to be able to mount the
sources.

This PR makes it possible.
  • Loading branch information
potiuk authored Nov 27, 2020
1 parent 6e9c110 commit c084393
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion breeze
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,6 @@ function breeze::parse_arguments() {
export GITHUB_REGISTRY_PUSH_IMAGE_TAG="${2}"
export CHECK_IMAGE_FOR_REBUILD="false"
export SKIP_BUILDING_PROD_IMAGE="true"
export MOUNT_LOCAL_SOURCES="false"
export SKIP_CHECK_REMOTE_IMAGE="true"
export FAIL_ON_GITHUB_DOCKER_PULL_ERROR="true"
shift 2
Expand Down
8 changes: 4 additions & 4 deletions scripts/in_container/run_ci_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,22 @@ elif [[ "${RES}" != "0" ]]; then
>&2 echo "*"
>&2 echo "* Run all tests:"
>&2 echo "*"
>&2 echo "* ./breeze --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --test-type ${TEST_TYPE} tests"
>&2 echo "* ./breeze --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --skip-mounting-local-sources --test-type ${TEST_TYPE} tests"
>&2 echo "*"
>&2 echo "* Enter docker shell:"
>&2 echo "*"
>&2 echo "* ./breeze --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --test-type ${TEST_TYPE} shell"
>&2 echo "* ./breeze --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --skip-mounting-local-sources --test-type ${TEST_TYPE} shell"
>&2 echo "*"
if [[ ${GITHUB_REGISTRY_PULL_IMAGE_TAG=} != "" ]]; then
>&2 echo "* When you do not have sources:"
>&2 echo "*"
>&2 echo "* Run all tests:"
>&2 echo "*"
>&2 echo "* ./breeze --github-image-id ${GITHUB_REGISTRY_PULL_IMAGE_TAG} --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --test-type ${TEST_TYPE} tests"
>&2 echo "* ./breeze --github-image-id ${GITHUB_REGISTRY_PULL_IMAGE_TAG} --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --skip-mounting-local-sources --test-type ${TEST_TYPE} tests"
>&2 echo "*"
>&2 echo "* Enter docker shell:"
>&2 echo "*"
>&2 echo "* ./breeze --github-image-id ${GITHUB_REGISTRY_PULL_IMAGE_TAG} --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --test-type ${TEST_TYPE} shell"
>&2 echo "* ./breeze --github-image-id ${GITHUB_REGISTRY_PULL_IMAGE_TAG} --backend ${BACKEND} ${EXTRA_ARGS}--python ${PYTHON_MAJOR_MINOR_VERSION} --db-reset --skip-mounting-local-sources --test-type ${TEST_TYPE} shell"
>&2 echo "*"
fi
>&2 echo "*"
Expand Down

0 comments on commit c084393

Please sign in to comment.