of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove

A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP, or an embedded errno. overlay_notify() incorrectly reports an error for NOTIFY_OK. Reported-by: [email protected] Signed-off-by: Frank Rowand <[email protected]> Signed-off-by: Rob Herring <[email protected]>
XGWang0 · Oct 19, 2017 · a1d19bd · a1d19bd
1 parent 34ca5d7
commit a1d19bd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
 
 		ret = blocking_notifier_call_chain(&overlay_notify_chain,
 						   action, &nd);
-		if (ret == NOTIFY_STOP)
+		if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
 			return 0;
 		if (ret) {
 			ret = notifier_to_errno(ret);