Skip to content

Commit

Permalink
ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int
Browse files Browse the repository at this point in the history
> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-1
> echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat
-bash: echo: write error: Invalid argument
> echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat
> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-2147483648

but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER"

v2: simplify to just proc_douintvec
Signed-off-by: Pavel Tikhomirov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Snorch authored and davem330 committed Jan 9, 2017
1 parent 67c408c commit b007f09
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/sysctl_net_ipv4.c
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ static struct ctl_table ipv4_net_table[] = {
.data = &init_net.ipv4.sysctl_tcp_notsent_lowat,
.maxlen = sizeof(unsigned int),
.mode = 0644,
.proc_handler = proc_dointvec,
.proc_handler = proc_douintvec,
},
{
.procname = "tcp_tw_reuse",
Expand Down

0 comments on commit b007f09

Please sign in to comment.