Ensure buffer for environment is large enough on NetBSD

Xierenjian · May 6, 2022 · 4f1269c · 4f1269c
1 parent 0388b30
commit 4f1269c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/netbsd/Platform.c b/netbsd/Platform.c
@@ -311,7 +311,13 @@ char* Platform_getProcessEnv(pid_t pid) {
    for (char** p = ptr; *p; p++) {
       size_t len = strlen(*p) + 1;
 
-      if (size + len > capacity) {
+      while (size + len > capacity) {
+         if (capacity > (SIZE_MAX / 2)) {
+            free(env);
+            env = NULL;
+            goto end;
+         }
+
          capacity *= 2;
          env = xRealloc(env, capacity);
       }
@@ -327,6 +333,7 @@ char* Platform_getProcessEnv(pid_t pid) {
       env[size + 1] = 0;
    }
 
+end:
    (void) kvm_close(kt);
    return env;
 }