Skip to content

Commit

Permalink
pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
dzhwinter committed Aug 24, 2018
1 parent 89f95ea commit c1ad52f
Show file tree
Hide file tree
Showing 20 changed files with 73 additions and 75 deletions.
2 changes: 1 addition & 1 deletion doc/fluid/dev/contribute_to_paddle_cn.md
2 changes: 1 addition & 1 deletion doc/fluid/dev/contribute_to_paddle_en.md
2 changes: 1 addition & 1 deletion doc/fluid/new_docs/advanced_usage/development/new_op.md
2 changes: 1 addition & 1 deletion doc/v2/dev/contribute_to_paddle_en.md
4 changes: 2 additions & 2 deletions paddle/fluid/framework/data_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ inline void VisitDataType(proto::VarType::Type type, Visitor visitor) {
PADDLE_THROW("Not supported %d", type);
}
}
#else
#else
// the msvc compiler do not implement two-stage name lookup correctly.
template <typename Visitor>
inline void VisitDataType(proto::VarType::Type type, Visitor visitor) {
Expand Down Expand Up @@ -91,7 +91,7 @@ inline void VisitDataType(proto::VarType::Type type, Visitor visitor) {
PADDLE_THROW("Not supported %d", type);
}
}
#endif // _WIN32
#endif // _WIN32

extern std::string DataTypeToString(const proto::VarType::Type type);
extern size_t SizeOfType(std::type_index type);
Expand Down
14 changes: 14 additions & 0 deletions paddle/fluid/framework/data_type_transform.cu
12 changes: 6 additions & 6 deletions paddle/fluid/framework/lod_tensor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ limitations under the License. */
#if defined(_WIN32)
#include "paddle/fluid/recordio/scanner.h"
#include "paddle/fluid/recordio/writer.h"
#endif // _WIN32
#endif // _WIN32

namespace paddle {
namespace framework {
Expand Down Expand Up @@ -337,14 +337,14 @@ class Writer {};
class Scanner {};
void WriteToRecordIO(recordio::Writer *writer,
const std::vector<LoDTensor> &tensor,
const platform::DeviceContext &dev_ctx) {
}
const platform::DeviceContext &dev_ctx) {}
bool ReadFromRecordIO(recordio::Scanner *scanner,
const platform::DeviceContext &dev_ctx,
std::vector<LoDTensor> *result_ptr) {
std::vector<LoDTensor> *result_ptr) {
PADDLE_ENFORCE("windows didn't supported recordio!.");
return true;}
#endif // _WIN32
return true;
}
#endif // _WIN32
std::vector<LoDTensor> LoDTensor::SplitLoDTensor(
const std::vector<platform::Place> places) const {
check_memory_size();
Expand Down
2 changes: 1 addition & 1 deletion paddle/fluid/framework/lod_tensor_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ TEST(LoDTensor, RecordIO) {
TestRecordIO<float>();
TestRecordIO<double>();
}
#endif // !defined(_WIN32)
#endif // !defined(_WIN32)

} // namespace framework
} // namespace paddle
2 changes: 1 addition & 1 deletion paddle/fluid/framework/rw_lock.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ limitations under the License. */

#if !defined(_WIN32)
#include <pthread.h>
#endif // !_WIN32
#endif // !_WIN32

#include "paddle/fluid/platform/enforce.h"

Expand Down
14 changes: 14 additions & 0 deletions paddle/fluid/framework/tensor_util.cu
12 changes: 6 additions & 6 deletions paddle/fluid/memory/detail/system_allocator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ limitations under the License. */
#include "paddle/fluid/memory/detail/system_allocator.h"

#ifdef _WIN32
#include <windows.h>
#include <malloc.h>
#include <windows.h>
#else
#include <sys/mman.h> // for mlock and munlock
#endif
#include <stdlib.h> // for malloc and free
#include <algorithm> // for std::max
#include <stdlib.h> // for malloc and free
#include <algorithm> // for std::max

#include "gflags/gflags.h"
#include "paddle/fluid/platform/assert.h"
Expand All @@ -44,15 +44,15 @@ namespace detail {
void* AlignedMalloc(size_t size) {
void* p = nullptr;
size_t alignment = 32ul;
#ifdef PADDLE_WITH_MKLDNN
#ifdef PADDLE_WITH_MKLDNN
// refer to https://github.com/01org/mkl-dnn/blob/master/include/mkldnn.hpp
// memory alignment
alignment = 4096ul;
#endif
#endif
#ifdef _WIN32
p = _aligned_malloc(size, alignment);
#else
PADDLE_ENFORCE_EQ(posix_memalign(&p, alignment, size), 0, "Alloc %ld error!",
PADDLE_ENFORCE_EQ(posix_memalign(&p, alignment, size), 0, "Alloc %ld error!",
size);
#endif
PADDLE_ENFORCE(p, "Fail to allocate CPU memory: size = %d .", size);
Expand Down
1 change: 0 additions & 1 deletion paddle/fluid/operators/math/math_function.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ limitations under the License. */
#include "paddle/fluid/platform/dynload/mklml.h"
#endif


#ifdef PADDLE_USE_OPENBLAS
#include <cblas.h>
#endif
Expand Down
15 changes: 8 additions & 7 deletions paddle/fluid/platform/cpu_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ limitations under the License. */
#include <sys/types.h>
#elif defined(_WIN32)
#define NOMINMAX
#include <windows.h>
#include <psapi.h>
#include <windows.h>
#else
#include <unistd.h>
#endif
Expand All @@ -47,8 +47,9 @@ DEFINE_uint64(initial_cpu_memory_in_mb,
#endif
"Initial CPU memory for PaddlePaddle, in MD unit.");
#else
DEFINE_uint64(initial_cpu_memory_in_mb, 500ul, "Initial CPU memory for PaddlePaddle, in MD unit.");
#endif // !defined(_WIN32)
DEFINE_uint64(initial_cpu_memory_in_mb, 500ul,
"Initial CPU memory for PaddlePaddle, in MD unit.");
#endif // !defined(_WIN32)

DEFINE_double(
fraction_of_cuda_pinned_memory_to_use, 0.5,
Expand All @@ -68,10 +69,10 @@ inline size_t CpuTotalPhysicalMemory() {
if (sysctl(mib, 2, &size, &len, NULL, 0) == 0) return (size_t)size;
return 0L;
#elif defined(_WIN32)
MEMORYSTATUSEX sMeminfo;
sMeminfo.dwLength = sizeof(sMeminfo);
GlobalMemoryStatusEx(&sMeminfo);
return sMeminfo.ullTotalPhys;
MEMORYSTATUSEX sMeminfo;
sMeminfo.dwLength = sizeof(sMeminfo);
GlobalMemoryStatusEx(&sMeminfo);
return sMeminfo.ullTotalPhys;
#else
int64_t pages = sysconf(_SC_PHYS_PAGES);
int64_t page_size = sysconf(_SC_PAGE_SIZE);
Expand Down
10 changes: 4 additions & 6 deletions paddle/fluid/platform/device_tracer.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License. */
#include <sys/time.h>
#else
#include <windows.h>
#endif // !_WIN32
#endif // !_WIN32

#include <time.h>
#include <chrono> // NOLINT
Expand All @@ -36,13 +36,11 @@ namespace platform {
inline uint64_t PosixInNsec() {
struct timeval tv;
gettimeofday(&tv, nullptr);
return 1000 * (static_cast<uint64_t>(tv.tv_sec) * 1000000 + tv.tv_usec);
return 1000 * (static_cast<uint64_t>(tv.tv_sec) * 1000000 + tv.tv_usec);
}
#else
inline uint64_t PosixInNsec() {
return static_cast<uint64_t>(0);
}
#endif // !_WIN32
inline uint64_t PosixInNsec() { return static_cast<uint64_t>(0); }
#endif // !_WIN32

// DeviceTracer performs the following tasks:
// 1. Register cuda callbacks for various events: kernel, memcpy, etc.
Expand Down
17 changes: 9 additions & 8 deletions paddle/fluid/platform/enforce.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ limitations under the License. */
#include <string>

#include "glog/logging.h"
#include "paddle/fluid/platform/port.h"
#include "paddle/fluid/platform/macros.h"
#include "paddle/fluid/platform/port.h"
#include "paddle/fluid/platform/port.h"
#include "paddle/fluid/string/printf.h"
#include "paddle/fluid/string/to_string.h"

Expand Down Expand Up @@ -261,20 +261,21 @@ inline void throw_on_error(T e) {
throw ::paddle::platform::EOFException("There is no next data.", __FILE__, \
__LINE__); \
} while (false)

#else
#define PADDLE_ENFORCE(...) ::paddle::platform::throw_on_error(__VA_ARGS__);
#endif
#else // !_WIN32
#else // !_WIN32
#define GLOG_NO_ABBREVIATED_SEVERITIES
// disable enforce, caused by the varardic macro exception error
#define PADDLE_THROW(x) \
do { \
throw std::make_exception_ptr(std::runtime_error("Windows disable the enforce.")); \
// disable enforce, caused by the varardic macro exception error
#define PADDLE_THROW(x) \
do { \
throw std::make_exception_ptr( \
std::runtime_error("Windows disable the enforce.")); \
} while (false)

#define PADDLE_ENFORCE(x) x
#endif // !_WIN32
#endif // !_WIN32

/*
* Some enforce helpers here, usage:
Expand Down
29 changes: 0 additions & 29 deletions paddle/fluid/platform/port.h
Original file line number Diff line number Diff line change
@@ -1,31 +1,3 @@
<<<<<<< HEAD
#pragma once

#include <string>
#include <stdexcept>

#if !defined(_WIN32)
#include <dlfcn.h> // for dladdr
#include <execinfo.h> // for backtrace
#else
#define NOMINMAX // windows min(), max() macro will mess std::min,max
#include <Shlwapi.h>
#include <Windows.h>
namespace {

static void* dlsym(void *handle, const char* symbol_name) {
FARPROC found_symbol;
found_symbol = GetProcAddress((HMODULE)handle, symbol_name);

if (found_symbol == NULL) {
throw std::runtime_error(std::string(symbol_name) + " not found.");
}
return (void*)found_symbol;
}
} // namespace anoymous

#endif
=======
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -63,4 +35,3 @@ static void* dlsym(void* handle, const char* symbol_name) {
}

#endif
>>>>>>> origin/develop

0 comments on commit c1ad52f

Please sign in to comment.