Fix null key in QoS (apache#14419)

* Fix null key * Fix style
Xwiam · Jul 12, 2024 · 6f4fcf4 · 6f4fcf4
1 parent f1da57d
commit 6f4fcf4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/GetConfig.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/GetConfig.java
@@ -175,6 +175,8 @@ private static void appendConfigs(
             return;
         }
 
+        id = id == null ? "(empty)" : id;
+
         plainOutput
                 .append(type)
                 .append(": ")
@@ -194,6 +196,8 @@ private static void appendConfig(
             return;
         }
 
+        id = id == null ? "(empty)" : id;
+
         plainOutput
                 .append(type)
                 .append(": ")

diff --git a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/GetConfigTest.java b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/GetConfigTest.java
@@ -74,6 +74,24 @@ void testAll() {
         Assertions.assertNotNull(new GetConfig(frameworkModel).execute(commandContext, null));
     }
 
+    @Test
+    void testEmptyId() {
+        FrameworkModel frameworkModel = new FrameworkModel();
+        ApplicationModel applicationModel1 = frameworkModel.newApplication();
+
+        applicationModel1.getApplicationConfigManager().setApplication(new ApplicationConfig("app1"));
+
+        ModuleModel moduleModel = applicationModel1.newModule();
+        ProviderConfig providerConfig1 = new ProviderConfig();
+        providerConfig1.setThreadname("test");
+        moduleModel.getConfigManager().addProvider(providerConfig1);
+
+        CommandContext commandContext = new CommandContext("getConfig");
+        commandContext.setHttp(true);
+
+        Assertions.assertNotNull(new GetConfig(frameworkModel).execute(commandContext, null));
+    }
+
     @Test
     void testFilter1() {
         FrameworkModel frameworkModel = new FrameworkModel();