Fixed #34349 -- Fixed FormSet.empty_form crash when deleting extra fo…

…rms is disabled.
Yako3 · Feb 20, 2023 · 6cbc403 · 6cbc403
1 parent 278881e
commit 6cbc403
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/django/forms/formsets.py b/django/forms/formsets.py
@@ -490,7 +490,9 @@ def add_fields(self, form, index):
                     required=False,
                     widget=self.get_ordering_widget(),
                 )
-        if self.can_delete and (self.can_delete_extra or index < initial_form_count):
+        if self.can_delete and (
+            self.can_delete_extra or (index is not None and index < initial_form_count)
+        ):
             form.fields[DELETION_FIELD_NAME] = BooleanField(
                 label=_("Delete"),
                 required=False,

diff --git a/tests/forms_tests/tests/test_formsets.py b/tests/forms_tests/tests/test_formsets.py
@@ -1480,6 +1480,7 @@ def test_disable_delete_extra_formset_forms(self):
         self.assertIn("DELETE", formset.forms[0].fields)
         self.assertNotIn("DELETE", formset.forms[1].fields)
         self.assertNotIn("DELETE", formset.forms[2].fields)
+        self.assertNotIn("DELETE", formset.empty_form.fields)
 
         formset = ChoiceFormFormset(
             data={