JENA-1595: Require log4j for cmds and distribution

YanNaingToe · Sep 27, 2018 · 87e70b0 · 87e70b0
1 parent 30feb28
commit 87e70b0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/apache-jena/pom.xml b/apache-jena/pom.xml
@@ -151,6 +151,20 @@
       <version>3.9.0-SNAPSHOT</version>
     </dependency>
 
+    <!-- Require a logging implementation -->
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-log4j12</artifactId>
+      <scope>compile</scope>
+    </dependency>
+
+    <dependency>
+      <groupId>log4j</groupId>
+      <artifactId>log4j</artifactId>
+      <scope>compile</scope>
+    </dependency>
+    <!-- Logging -->
+
     <dependency>
       <groupId>org.apache.jena</groupId>
       <artifactId>jena-cmds</artifactId>

diff --git a/jena-cmds/pom.xml b/jena-cmds/pom.xml
@@ -67,16 +67,20 @@
       <artifactId>slf4j-api</artifactId>
     </dependency>
 
-    <!-- Require a logging implementation -->
+    <!-- Require a logging implementation 
+         It is <scope>test</scope> from the parent otherwise.
+    -->
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-log4j12</artifactId>
+      <scope>runtime</scope>
     </dependency>
 
     <dependency>
       <groupId>log4j</groupId>
       <artifactId>log4j</artifactId>
-    </dependency> 
+      <scope>runtime</scope>
+    </dependency>
 
     <!-- Testing -->
     <dependency>