Add drake_cc_package_library and library_lint

YinjieLin · Apr 17, 2018 · f942383 · f942383
1 parent 87ed4b3
commit f942383
Show file tree

Hide file tree

Showing 41 changed files with 598 additions and 110 deletions.
diff --git a/automotive/maliput/api/BUILD.bazel b/automotive/maliput/api/BUILD.bazel
@@ -1,12 +1,24 @@
 # -*- python -*-
 
-load("//tools:drake.bzl", "drake_cc_googletest", "drake_cc_library")
+load(
+    "@drake//tools/skylark:drake_cc.bzl",
+    "drake_cc_googletest",
+    "drake_cc_library",
+    "drake_cc_package_library",
+)
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "api",
+    deps = [
+        ":everything",
+    ],
+)
+
+drake_cc_library(
+    name = "everything",
     srcs = [
         "lane.cc",
         "lane_data.cc",
@@ -25,6 +37,7 @@ drake_cc_library(
         "segment.h",
         "type_specific_identifier.h",
     ],
+    visibility = ["//visibility:private"],
     deps = [
         "//common:default_scalars",
         "//common:essential",

diff --git a/automotive/maliput/api/test_utilities/BUILD.bazel b/automotive/maliput/api/test_utilities/BUILD.bazel
@@ -1,16 +1,20 @@
 # -*- python -*-
 
-load("//tools:drake.bzl", "drake_cc_library")
+load(
+    "@drake//tools/skylark:drake_cc.bzl",
+    "drake_cc_library",
+    "drake_cc_package_library",
+)
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-# This should encompass every cc_library in this package.
-drake_cc_library(
+drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
     deps = [
         ":maliput_types_compare",
+        ":rules_test_utilities",
     ],
 )
 

diff --git a/automotive/maliput/dragway/BUILD.bazel b/automotive/maliput/dragway/BUILD.bazel
@@ -1,17 +1,25 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "dragway",
+    deps = [
+        ":everything",
+    ],
+)
+
+drake_cc_library(
+    name = "everything",
     srcs = [
         "branch_point.cc",
         "junction.cc",
@@ -26,6 +34,7 @@ drake_cc_library(
         "road_geometry.h",
         "segment.h",
     ],
+    visibility = ["//visibility:private"],
     deps = [
         "//automotive/maliput/api",
         "//common:essential",

diff --git a/automotive/maliput/monolane/BUILD.bazel b/automotive/maliput/monolane/BUILD.bazel
@@ -1,10 +1,11 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load(
     "@drake//tools/skylark:drake_py.bzl",
@@ -14,10 +15,8 @@ load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "monolane",
-    srcs = [],
-    hdrs = [],
     deps = [
         ":builder",
         ":lanes",

diff --git a/automotive/maliput/multilane/BUILD.bazel b/automotive/maliput/multilane/BUILD.bazel
@@ -1,10 +1,11 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load(
     "@drake//tools/skylark:drake_py.bzl",
@@ -14,10 +15,8 @@ load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "multilane",
-    srcs = [],
-    hdrs = [],
     deps = [
         ":builder",
         ":lanes",

diff --git a/automotive/maliput/multilane/test_utilities/BUILD.bazel b/automotive/maliput/multilane/test_utilities/BUILD.bazel
@@ -1,13 +1,16 @@
 # -*- python -*-
 # This file contains rules for Bazel; see drake/doc/bazel.rst.
 
-load("//tools:drake.bzl", "drake_cc_library")
+load(
+    "@drake//tools/skylark:drake_cc.bzl",
+    "drake_cc_library",
+    "drake_cc_package_library",
+)
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-# This should encompass every cc_library in this package.
-drake_cc_library(
+drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
     deps = [

diff --git a/automotive/maliput/rndf/BUILD.bazel b/automotive/maliput/rndf/BUILD.bazel
@@ -1,19 +1,18 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "rndf",
-    srcs = [],
-    hdrs = [],
     deps = [
         ":builder",
         ":lanes",

diff --git a/automotive/maliput/rndf/test_utilities/BUILD.bazel b/automotive/maliput/rndf/test_utilities/BUILD.bazel
@@ -1,12 +1,15 @@
 # -*- python -*-
 
-load("//tools:drake.bzl", "drake_cc_library")
+load(
+    "@drake//tools/skylark:drake_cc.bzl",
+    "drake_cc_library",
+    "drake_cc_package_library",
+)
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-# This should encompass every cc_library in this package.
-drake_cc_library(
+drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
     deps = [

diff --git a/automotive/maliput/simplerulebook/BUILD.bazel b/automotive/maliput/simplerulebook/BUILD.bazel
@@ -1,18 +1,17 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "simplerulebook",
-    srcs = [],
-    hdrs = [],
     deps = [
         ":simple_rulebook",
         ":yaml_io",

diff --git a/automotive/maliput/utility/BUILD.bazel b/automotive/maliput/utility/BUILD.bazel
@@ -1,10 +1,11 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
+    "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
-    "drake_cc_binary",
+    "drake_cc_package_library",
 )
 load(
     "@drake//tools/skylark:drake_py.bzl",
@@ -14,8 +15,15 @@ load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-drake_cc_library(
+drake_cc_package_library(
     name = "utility",
+    deps = [
+        ":everything",
+    ],
+)
+
+drake_cc_library(
+    name = "everything",
     srcs = [
         "generate_obj.cc",
         "generate_urdf.cc",
@@ -24,6 +32,7 @@ drake_cc_library(
         "generate_obj.h",
         "generate_urdf.h",
     ],
+    visibility = ["//visibility:private"],
     deps = [
         "//automotive/maliput/api",
         "//math:geometric_transform",

diff --git a/common/BUILD.bazel b/common/BUILD.bazel
@@ -1,10 +1,11 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_binary",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load(
     "@drake//tools/skylark:drake_py.bzl",
@@ -16,11 +17,8 @@ load("//tools/lint:lint.bzl", "add_lint_tests")
 
 package(default_visibility = ["//visibility:public"])
 
-# This should encompass every non-testonly cc_library in this package,
-# except for items that should only ever be linked into main() programs.
-drake_cc_library(
+drake_cc_package_library(
     name = "common",
-    srcs = [],
     deps = [
         ":autodiff",
         ":autodiffxd_make_coherent",
@@ -52,9 +50,6 @@ drake_cc_library(
         ":type_safe_index",
         ":unused",
     ],
-    # Intentionally excluded items:
-    # - text_logging_gflags
-    # - text_logging_gflags_h
 )
 
 # A library of things that EVERYONE should want and MUST EAT.
@@ -379,6 +374,11 @@ drake_cc_library(
         "//tools/cc_toolchain:linux": ["-pthread"],
         "//conditions:default": [],
     }),
+    tags = [
+        # Don't add this library into the ":common" package library.
+        # Only programs with a main() function should ever use this header.
+        "exclude_from_package",
+    ],
     deps = [
         ":essential",
         "@gflags",
@@ -391,6 +391,12 @@ drake_cc_library(
 drake_cc_library(
     name = "text_logging_gflags_h",
     hdrs = ["text_logging_gflags.h"],
+    tags = [
+        # Don't add this library into the ":common" package library.
+        # This rule should only be used for install purposes.
+        "exclude_from_package",
+    ],
+    # This rule should only be used for install purposes.
     visibility = ["//tools/install/libdrake:__pkg__"],
 )
 

diff --git a/common/test_utilities/BUILD.bazel b/common/test_utilities/BUILD.bazel
@@ -1,9 +1,10 @@
 # -*- python -*-
 
 load(
-    "//tools:drake.bzl",
+    "@drake//tools/skylark:drake_cc.bzl",
     "drake_cc_googletest",
     "drake_cc_library",
+    "drake_cc_package_library",
 )
 load(
     "@drake//tools/skylark:drake_py.bzl",
@@ -19,11 +20,9 @@ exports_files([
 
 # This should encompass every cc_library in this package, except for items that
 # should only ever be linked into main() programs.
-drake_cc_library(
+drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
-    srcs = [],
-    hdrs = [],
     deps = [
         ":eigen_geometry_compare",
         ":eigen_matrix_compare",
@@ -34,8 +33,6 @@ drake_cc_library(
         ":random_polynomial_matrix",
         ":symbolic_test_util",
     ],
-    # Intentionally excluded items:
-    # - drake_cc_googletest_main
 )
 
 drake_cc_library(
@@ -105,12 +102,15 @@ drake_cc_library(
     ],
 )
 
-# This is only intended to be used by the drake_cc_googletest() macro.
-# Do not add it to ":test_utilities".
 drake_cc_library(
     name = "drake_cc_googletest_main",
     testonly = 1,
     srcs = ["drake_cc_googletest_main.cc"],
+    tags = [
+        # This is only intended to be used by the drake_cc_googletest() macro.
+        # Don't add this library into the ":test_utilities" package library.
+        "exclude_from_package",
+    ],
     deps = [
         "//common:text_logging_gflags",
         "@gtest//:without_main",

diff --git a/examples/rod2d/BUILD.bazel b/examples/rod2d/BUILD.bazel
@@ -51,7 +51,6 @@ drake_cc_library(
         ":rod2d_state_vector",
         "//common:essential",
         "//multibody/constraint",
-        "//multibody/constraint:constraint_solver",
         "//solvers:mathematical_program",
         "//systems/framework:leaf_system",
         "//systems/rendering:pose_vector",
@@ -66,7 +65,7 @@ drake_cc_googletest(
         ":rod2d",
         "//common:essential",
         "//common/test_utilities:eigen_matrix_compare",
-        "//multibody/constraint:constraint_solver",
+        "//multibody/constraint",
         "//systems/analysis",
     ],
 )