Skip to content

Commit

Permalink
Fix missing blocking params in conv im2col code path.
Browse files Browse the repository at this point in the history
Summary: Add blocking params as argument of rowOffsetBufferSize() so the allocated vector will be sized correctlly.

Reviewed By: dskhudia, jianyuh

Differential Revision: D16348913

fbshipit-source-id: c70a05f2f69db3ce71ec2c27a8db4d143649ddd6
  • Loading branch information
evhunter authored and facebook-github-bot committed Jul 18, 2019
1 parent 6e903d5 commit 28b7332
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/FbgemmConv.cc
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ int fbgemmConv(
// All other convolutions go through im2col-based implementation
// std::cout << "Im2col path" << std::endl;
std::vector<int32_t> row_offset_buf(
PackAWithIm2Col<uint8_t, ACC_T, SPATIAL_DIM>::rowOffsetBufferSize());
PackAWithIm2Col<uint8_t, ACC_T, SPATIAL_DIM>
::rowOffsetBufferSize(blocking_params));

const std::int32_t* b_zero_point = outProcess.getBZeroPoint();
bool b_symmetric = b_zero_point[0] == 0;
Expand Down

0 comments on commit 28b7332

Please sign in to comment.