Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- RR: Tie player input to framerate #15

Closed
wants to merge 17 commits into from
Closed

- RR: Tie player input to framerate #15

wants to merge 17 commits into from

Conversation

mjr4077au
Copy link
Member

This set of commits is to bring the input code of RR up to the same level as the pull request for Duke 3D.

More effort was needed here as the RR code is a mess and has not been adequately kept up to date with Duke3D code.

Only Duke 3D and Redneck Rampage have been tested. Rides Again and Deer Hunting do not work against the current versions of Raze irrespective of these changes and therefore are untested.

@coelckers
Copy link
Member

Why didn't you report that RRRA and Deer Huntin' were broken as a bug?

@mjr4077au
Copy link
Member Author

I'm sorry, I thought there was no expectation for them to be working (at least or Dee Huntin'). I'll report the issues shortly.

Any thoughts or feedback regarding this and the other pull request? Do you need more time to review/test them, etc?

@coelckers
Copy link
Member

I already fixed RRRA and Deer Huntin's startup. That was caused by some incomplete and abandoned refactoring which I undid again. I just didn't know they were broken.

Regarding the features, be advised that I am currently not working on Raze except for fixing serious bugs I am made aware of. Too much stress because of coronavirus interfering with normal work patterns. So this probably won't change for the coming weeks. :(

I'm afraid that this also means I cannot do the needed review work for these PRs for the time being. Just make sure they work and don't get closedd and once I can invest more time here again they should be merged.

@mjr4077au
Copy link
Member Author

mjr4077au commented Mar 18, 2020

RRRA and RRDH start but I get no menu, just a tiled background image and I have to quit via taskmgr. I'll double-check it's nothing to do with bad files on my end.

Completely understood about the PRs and whatnot, just look after No. 1 for now :). I'll make sure they stay open. They work against the current master and played through a number of levels with no issues.

Stay safe!

@coelckers
Copy link
Member

I already fixed it, Pulling again should give you a working version.

@mjr4077au
Copy link
Member Author

Ah no worries, I misunderstood sorry. I guess more effort towards that consolidation can occur in the future :)

@mjr4077au
Copy link
Member Author

Now that RRRA is working, I was able to test the commits out. Some work was needed so I've pushed more changes. I was able to simplify the code in these functions significantly.

For Deer Huntin', the code in master doesn't work. The viewport is constantly held ~45 degrees from centre and you can't move it. The input changes in this pull request repair this by happenstance.

@coelckers
Copy link
Member

Merged manually

@coelckers coelckers closed this Mar 20, 2020
@mjr4077au mjr4077au deleted the RR_TieInputToFramerate branch March 20, 2020 20:26
coelckers added a commit that referenced this pull request Sep 16, 2020
A nearly typical problem of this code. Not all relevant properties of the camera target were changed at once - there was a two frame discrepancy in which the camera pointed in some undefined direction after the change.

Fixes #15
@Talon1024 Talon1024 mentioned this pull request Oct 11, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants