Game main loop amendments #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove MoveLoop() as it's only ever called by RunLevel(). - Continuously call getinput() and domovethings() within the game's tic rate.
- Replace if statement containing nested do/while loop with a while loop.
|
Please split this in two, one update for Duke/RR and the SW update - I'd like to be able to do one without the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started on some input improvements for SW. The changes to the main game loop do make an noticable improvement to input performance.
I have more changes planned to bring things up to Duke 3D levels but submitting this now as the current crisis is starting to impact my ability to spend time on this.
Lastly, a slight tweak to my previous PR for Duke3D and RR.
Eliminating the if statement with the nested do/while loop by just using a while loop achieves the same result and simplifies the code by removing a near duplicate check.
The contents of the if statement always need calling at least once, so it might as well be called at least once in a while loop.