cmd: Fix potential memory leak

Signed-off-by: Pavel Borzenkov <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
Zaelot · Nov 7, 2011 · 47e8dd8 · 47e8dd8
1 parent ba7806a
commit 47e8dd8
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/cmd.c b/cmd.c
@@ -329,16 +329,21 @@ char **breakline(char *input, int *count)
     int c = 0;
     char *p;
     char **rval = calloc(sizeof(char *), 1);
+    char **tmp;
 
     while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
         if (!*p) {
             continue;
         }
         c++;
-        rval = realloc(rval, sizeof(*rval) * (c + 1));
-        if (!rval) {
+        tmp = realloc(rval, sizeof(*rval) * (c + 1));
+        if (!tmp) {
+            free(rval);
+            rval = NULL;
             c = 0;
             break;
+        } else {
+            rval = tmp;
         }
         rval[c - 1] = p;
         rval[c] = NULL;