Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Chili.Object.AddChild #5453

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

XNTEABDSC
Copy link
Contributor

When use index, AddChild forgot to

children[hobj] = index
children[objDirect] = index

@GoogleFrog
Copy link
Contributor

Does anything use index currently?

@XNTEABDSC
Copy link
Contributor Author

layoutpanel use index to sort controls.
RemoveChild do nothing if not self.children[childDirect]. then add it again will cause "There is already a control with the name"

@GoogleFrog
Copy link
Contributor

Sorry, I mean does anything use the index parameter in AddChild(obj, dontUpdate, index)?

@XNTEABDSC
Copy link
Contributor Author

In zk, none.

But people may use it.

@GoogleFrog GoogleFrog merged commit d6f0f73 into ZeroK-RTS:master Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants