-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share feature #2728
Open
myxmaster
wants to merge
2
commits into
ZeusLN:master
Choose a base branch
from
myxmaster:copy_and_share_invoice
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add share feature #2728
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| import * as React from 'react'; | ||
| import { Platform, TouchableOpacity } from 'react-native'; | ||
|
|
||
| import QRCode from 'react-native-qrcode-svg'; | ||
| import { captureRef } from 'react-native-view-shot'; | ||
| import Share from 'react-native-share'; | ||
| import { Icon } from 'react-native-elements'; | ||
|
|
||
| import Button from './../components/Button'; | ||
|
|
||
| import { localeString } from './../utils/LocaleUtils'; | ||
| import { themeColor } from './../utils/ThemeUtils'; | ||
|
|
||
| type QRCodeElement = React.ElementRef<typeof QRCode>; | ||
|
|
||
| interface ShareButtonProps { | ||
| value: string; | ||
| qrRef: React.RefObject<QRCodeElement> | null; | ||
| title?: string; | ||
| icon?: any; | ||
| noUppercase?: boolean; | ||
| iconOnly?: boolean; | ||
| onPress: () => Promise<void>; | ||
| onShareComplete?: () => void; | ||
| } | ||
|
|
||
| export default class ShareButton extends React.Component<ShareButtonProps> { | ||
| handlePress = async () => { | ||
| const { onPress } = this.props; | ||
| await onPress(); | ||
| await this.shareContent(); | ||
| }; | ||
|
|
||
| shareContent = async () => { | ||
| const { value, qrRef, onShareComplete } = this.props; | ||
| try { | ||
| if (!qrRef?.current) { | ||
| return; | ||
| } | ||
|
|
||
| const svgElement = qrRef.current; | ||
| const base64Data = await captureRef(svgElement, { | ||
| format: 'png', | ||
| quality: 1 | ||
| }); | ||
|
|
||
| await Share.open({ | ||
| message: value, | ||
| url: base64Data | ||
| }); | ||
| } catch (error) { | ||
| // Share API throws error when share sheet closes, regardless of success | ||
| console.log('Error in shareContent:', error); | ||
| } finally { | ||
| onShareComplete?.(); | ||
| } | ||
| }; | ||
|
|
||
| render() { | ||
| const { title, icon, noUppercase, iconOnly } = this.props; | ||
|
|
||
| if (iconOnly) { | ||
| return ( | ||
| <TouchableOpacity | ||
| // "padding: 5" leads to a larger area where users can click on | ||
| style={{ padding: 5 }} | ||
| onPress={this.handlePress} | ||
| > | ||
| <Icon | ||
| name={'share'} | ||
| size={27} | ||
| color={themeColor('secondaryText')} | ||
| /> | ||
| </TouchableOpacity> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Button | ||
| title={title || localeString('general.share')} | ||
| icon={ | ||
| icon | ||
| ? icon | ||
| : { | ||
| name: 'share', | ||
| size: 25 | ||
| } | ||
| } | ||
| containerStyle={{ | ||
| marginTop: 10, | ||
| marginBottom: Platform.OS === 'android' ? 0 : 20 | ||
| }} | ||
| onPress={this.handlePress} | ||
| secondary | ||
| noUppercase={noUppercase} | ||
| /> | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myxmaster It looks like the QR logo issue on iOS happens because the capture runs before the logo fully loads. Try adding a 500ms delay here — should fix it!
await new Promise((resolve) => setTimeout(resolve, 500));There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, thanks for looking into it! I will try to fix it, if possible without a static timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhamkmr04 Can you please test if latest commit fixes the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we still have that issue in iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm ok. Any other idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's see if @kaloudis has an idea.
An additional 500ms delay is not exactly nice for performance...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's see if @kaloudis has an idea.
An additional 500ms delay is not exactly nice for performance...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup I agree. 50ms delay is also working though if we dont find any other solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that would be an acceptable workaround, but still not really cool :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not ideal. Let's see if we can figure out an alternative approach.