Fix: duplicate elements using ng-if in wrapper element mihnsen#5

ZhiguoZhang · May 7, 2017 · e3696ca · e3696ca
1 parent bacacfb
commit e3696ca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/dist/ui-carousel.js b/dist/ui-carousel.js
@@ -646,7 +646,7 @@ angular.module('ui.carousel.directives').directive('uiCarousel', ['$compile', '$
       onAfterChange: '&',
       onInit: '&'
     },
-    compile: function compile(el) {
+    link: function link($scope, el) {
       var template = angular.element($templateCache.get('ui-carousel/carousel.template.html'));
 
       // dynamic injections to override the inner layers' components
@@ -664,11 +664,8 @@ angular.module('ui.carousel.directives').directive('uiCarousel', ['$compile', '$
         }
       });
 
-      return function ($scope, el) {
-        // Compile
-        var compiledElement = $compile(templateInstance)($scope);
-        el.addClass('ui-carousel').html('').append(compiledElement);
-      };
+      var compiledElement = $compile(templateInstance)($scope);
+      el.addClass('ui-carousel').html('').append(compiledElement);
     },
 
 

diff --git a/dist/ui-carousel.min.js b/dist/ui-carousel.min.js