Fix warning "Use of uninitialized value in ...".

If the list has only one item avoid sort subroutine.
ZhouyihaiDing · Nov 18, 2006 · 2e17a97 · 2e17a97
1 parent 74ddbd8
commit 2e17a97
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/tests/ftp.pm b/tests/ftp.pm
@@ -55,12 +55,14 @@ sub pidfromfile {
         if(open(PIDF, "<$pidfile")) {
             my $pidline = <PIDF>;
             close(PIDF);
-            chomp $pidline;
-            $pidline =~ s/^\s+//;
-            $pidline =~ s/\s+$//;
-            $pidline =~ s/^[+-]?0+//;
-            if($pidline =~ $pidpattern) {
-                $pid = $1;
+            if($pidline) {
+                chomp $pidline;
+                $pidline =~ s/^\s+//;
+                $pidline =~ s/\s+$//;
+                $pidline =~ s/^[+-]?0+//;
+                if($pidline =~ $pidpattern) {
+                    $pid = $1;
+                }
             }
         }
     }
@@ -150,6 +152,13 @@ sub signalpids {
     if((not defined $signal) || (not defined $pids)) {
         return;
     }
+    if($pids !~ /\s+/) {
+        # avoid sorting if only one pid
+        if(checkalivepid($pids) > 0) {
+            kill($signal, $pids);
+        }
+        return;
+    }
     my $prev = 0;
     for(sort({$a <=> $b} split(" ", $pids))) {
         if($_ =~ $pidpattern) {