Skip to content

Commit

Permalink
remove wip notice on phase 0 specs
Browse files Browse the repository at this point in the history
  • Loading branch information
djrtwo committed Nov 4, 2020
1 parent cd7b105 commit 7589af8
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 27 deletions.
2 changes: 1 addition & 1 deletion configs/minimal/phase0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ SECONDS_PER_ETH1_BLOCK: 14
# Ethereum Goerli testnet
DEPOSIT_CHAIN_ID: 5
DEPOSIT_NETWORK_ID: 5
# **TBD**
# Configured on a per testnet basis
DEPOSIT_CONTRACT_ADDRESS: 0x1234567890123456789012345678901234567890


Expand Down
6 changes: 1 addition & 5 deletions specs/phase0/beacon-chain.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Ethereum 2.0 Phase 0 -- The Beacon Chain

**Notice**: This document is a work-in-progress for researchers and implementers.

## Table of contents
<!-- TOC -->
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
Expand Down Expand Up @@ -177,7 +175,7 @@ The following values are (non-configurable) constants used throughout the specif

## Configuration

*Note*: The default mainnet configuration values are included here for spec-design purposes. The different configurations for mainnet, testnets, and YAML-based testing can be found in the [`configs/constant_presets`](../../configs) directory. These configurations are updated for releases and may be out of sync during `dev` changes.
*Note*: The default mainnet configuration values are included here for illustrative purposes. The different configurations for mainnet, testnets, and YAML-based testing can be found in the [`configs/constant_presets`](../../configs) directory.

### Misc

Expand Down Expand Up @@ -1191,8 +1189,6 @@ def is_valid_genesis_state(state: BeaconState) -> bool:
return True
```

*Note*: The `is_valid_genesis_state` function (including `MIN_GENESIS_TIME` and `MIN_GENESIS_ACTIVE_VALIDATOR_COUNT`) is a placeholder for testing. It has yet to be finalized by the community, and can be updated as necessary.

### Genesis block

Let `genesis_block = BeaconBlock(state_root=hash_tree_root(genesis_state))`.
Expand Down
2 changes: 0 additions & 2 deletions specs/phase0/deposit-contract.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Ethereum 2.0 Phase 0 -- Deposit Contract

**Notice**: This document is a work-in-progress for researchers and implementers.

## Table of contents
<!-- TOC -->
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
Expand Down
2 changes: 0 additions & 2 deletions specs/phase0/fork-choice.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Ethereum 2.0 Phase 0 -- Beacon Chain Fork Choice

**Notice**: This document is a work-in-progress for researchers and implementers.

## Table of contents
<!-- TOC -->
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
Expand Down
2 changes: 0 additions & 2 deletions specs/phase0/p2p-interface.md
Original file line number Diff line number Diff line change
Expand Up @@ -1219,8 +1219,6 @@ For minimum and maximum allowable slot broadcast times,
Although messages can at times be eagerly gossiped to the network,
the node's fork choice prevents integration of these messages into the actual consensus until the _actual local start_ of the designated slot.

The value of this constant is currently a placeholder and will be tuned based on data observed in testnets.

### Why are there `ATTESTATION_SUBNET_COUNT` attestation subnets?

Depending on the number of validators, it may be more efficient to group shard subnets and might provide better stability for the gossipsub channel.
Expand Down
2 changes: 1 addition & 1 deletion specs/phase0/validator.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Ethereum 2.0 Phase 0 -- Honest Validator

**Notice**: This document is a work-in-progress for researchers and implementers. This is an accompanying document to [Ethereum 2.0 Phase 0 -- The Beacon Chain](./beacon-chain.md), which describes the expected actions of a "validator" participating in the Ethereum 2.0 protocol.
This is an accompanying document to [Ethereum 2.0 Phase 0 -- The Beacon Chain](./beacon-chain.md), which describes the expected actions of a "validator" participating in the Ethereum 2.0 protocol.

## Table of contents

Expand Down
2 changes: 0 additions & 2 deletions specs/phase0/weak-subjectivity.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Ethereum 2.0 Phase 0 -- Weak Subjectivity Guide

**Notice**: This document is a work-in-progress for researchers and implementers.

## Table of contents

<!-- TOC -->
Expand Down
2 changes: 0 additions & 2 deletions ssz/simple-serialize.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# SimpleSerialize (SSZ)

**Notice**: This document is a work-in-progress describing typing, serialization, and Merkleization of Eth2 objects.

## Table of contents
<!-- TOC -->
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
Expand Down
10 changes: 0 additions & 10 deletions tests/core/pyspec/eth2spec/test/phase0/genesis/test_validity.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,6 @@ def test_is_valid_genesis_state_true_more_balance(spec):
yield from run_is_valid_genesis_state(spec, state, valid=True)


# TODO: not part of the genesis function yet. Erroneously merged.
# @with_phases([PHASE0])
# @spec_test
# def test_is_valid_genesis_state_false_not_enough_balance(spec):
# state = create_valid_beacon_state(spec)
# state.validators[0].effective_balance = spec.MAX_EFFECTIVE_BALANCE - 1
#
# yield from run_is_valid_genesis_state(spec, state, valid=False)


@with_phases([PHASE0])
@spec_test
@single_phase
Expand Down

0 comments on commit 7589af8

Please sign in to comment.