contrib: Add clboss-channel-stats to summarize fee income performance #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksedgwic
force-pushed
the
2024-07-clboss-channel-stats
branch
from
b2ce357 to
82446d0
Compare
|
That was my first approach but it is quite a bit of code and would risk
CLBOSS stability itself. Putting it outside is very straightforward and I
think much less risky.
I think we should experiment with it outside first
…--
Ken Sedgwick
Bonsai Software, Inc.
http://www.bonsai.com/ken/
(510) 269-7334
***@***.***
Public Key: http://www.bonsai.com/ken/ken.asc
GPG Fingerprint: 4695 E5B8 F781 BF85 4326 9639 BBFC E515 8602 5550
On Fri, Aug 2, 2024, 00:18 Vincenzo Palazzo ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM, do you think that this is too hard to include inside CLBOSS?
—
Reply to this email directly, view it on GitHub
<#226 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJNPWXAR4SHRDCGAMWFNDZPMXC3AVCNFSM6AAAAABLZLPKRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJUHA2DMMBXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tsjk
reviewed
Aug 2, 2024
contrib/clboss-routing-stats
Outdated
| peers = {} | ||
| for channel in channels_data: | ||
| # Skip channels that are closed | ||
| if channel.get("state") == "ONCHAIN": |
There was a problem hiding this comment.
I'd skip all states except CHANNELD_NORMAL.
This script produces a summary of channel stats, sorted by routing performance: - Displays PeerID, SCID, and Alias for each channel - Sorts first by net fees (income - expenses) (descending) - Then sorts by "Success Per Day" (SPD) (descending) - Then sorts by Age in days (ascending) The channels at the top of the list are good, the ones at the bottom are bad.
ksedgwic
force-pushed
the
2024-07-clboss-channel-stats
branch
from
82446d0 to
4f60685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script produces a summary of channel routing stats, sorted by performance:
The channels at the top of the list are good, the ones at the bottom are bad.