Centralized size settings #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ZmnSCPxj and Happy New Year! I like how this will permit cleaner addition of more options in the future and therefore prefer it to my own approach. I have taken a cursory look over the changes and these also look good to me (also, it compiles on my machine!), but I still have not tested it. I do notice that it is missing updated documentation, is this something that you you plan to add? |
ZmnSCPxj
force-pushed
the
centralized-size-settings
branch
from
b3f31a7 to
c4a30a2
Compare
ZmnSCPxj
force-pushed
the
centralized-size-settings
branch
from
c4a30a2 to
830715a
Compare
ZmnSCPxj
force-pushed
the
centralized-size-settings
branch
from
830715a to
a34b8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #74
This centralizes the size settings into a single module, which will then emit a message containing the size settings. As noted in #86, other modules need information like the minimum channel size as well.
@willcl-ark