Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment tracking with W&B #49

Merged
merged 16 commits into from
Sep 30, 2021

Conversation

dmitryduev
Copy link
Collaborator

@dmitryduev dmitryduev commented Sep 15, 2021

This PR adds basic experiment tracking with Weights & Biases for DNN training.

image

@dmitryduev dmitryduev marked this pull request as ready for review September 17, 2021 23:45
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like. Might want a little more pointer to w+b doc's stuff.

# value should refer to features section of this config
features: phenomenological
# our "labels" are floats [0., 0.25, 0.5, 0.75, 1.]
threshold: 0.7
# balance ratio for the prevalent class. leave as null to use all available data
threshold: 0.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, good question :) No idea, but I don't think it matters that much.

doc/usage.md Show resolved Hide resolved
time_tag = datetime.datetime.utcnow().strftime("%Y%m%d_%H%M%S")

if not kwargs.get("test", False):
wandb.login(key=self.config["wandb"]["token"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to where to documentation for where to grab one's token?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W&B's wizard will actually print out the url if you're running it the first time from the command line. Added anyways.

@dmitryduev
Copy link
Collaborator Author

@mcoughlin mind merging once the CI is green?

@dannygoldstein
Copy link
Member

😍

@mcoughlin
Copy link
Collaborator

@dmitryduev I merge now?

@dmitryduev
Copy link
Collaborator Author

@mcoughlin actually, let me add one more thing (I don't track test acc/precision/etc). I'll ping you.

@dmitryduev
Copy link
Collaborator Author

@mcoughlin should be ready for re-review.

@mcoughlin
Copy link
Collaborator

Beautiful.

@mcoughlin mcoughlin merged commit 8625efa into ZwickyTransientFacility:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants