Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify fields to exclude from feat gen/inference #566

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Apr 2, 2024

This PR allows a user to list fields to exclude from feature generation/inference in the config file (under fields_to_exclude). This prevents duplication of effort even if completed field files are not present locally.

@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 2, 2024 17:51 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 2, 2024 17:51 — with GitHub Actions Inactive
@bfhealy bfhealy requested a review from mcoughlin April 2, 2024 17:52
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2243,3 +2243,7 @@ inference:
# - 852
# - 853
path_to_preds:

# Some fields may already be comleted and should be excluded from subsequent feature generation/inference
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed

@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 2, 2024 18:10 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 2, 2024 18:10 — with GitHub Actions Inactive
@bfhealy bfhealy merged commit 2738c46 into ZwickyTransientFacility:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants