Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype bug in combine-preds field lists #577

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Apr 9, 2024

This PR fixes a bug that mixed int and str types in the fields lists of combine_preds.py. The saved list now contains integer fields numbers instead of strings, but the code converts back to "field_N" format when checking existing files saved in that format.

@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 9, 2024 15:18 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 9, 2024 15:18 — with GitHub Actions Inactive
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 9, 2024 15:26 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request April 9, 2024 15:26 — with GitHub Actions Inactive
@bfhealy bfhealy merged commit e96dfe0 into ZwickyTransientFacility:main Apr 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants