Skip to content

Commit

Permalink
[fuchsia] Add libbackend_fuchsia_globals.so to common_libs (flutter#4…
Browse files Browse the repository at this point in the history
…9484)

The libbackend_fuchsia_globals.so is now required by libsyslog.so, so
include it in the list of Fuchsia common_libs.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

b/315973146

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x ] All existing and new tests are passing.

---------

Co-authored-by: skia-flutter-autoroll <[email protected]>
Co-authored-by: Michael Brase <[email protected]>
  • Loading branch information
3 people authored Jan 4, 2024
1 parent ab4098c commit 28ae9e3
Show file tree
Hide file tree
Showing 4 changed files with 122 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ deps = {
'packages': [
{
'package': 'fuchsia/sdk/core/linux-amd64',
'version': 'CGyrUgA1M1yFx5N5C1aFQ_Q4Y5uP_FhxctN_UCZ9BugC'
'version': 'Wgogr8K1YZdo7yOnnGHWa2NBIvSTD6v8JIwlA8m-4oUC'
}
],
'condition': 'host_os == "linux" and not download_fuchsia_sdk',
Expand Down
1 change: 1 addition & 0 deletions ci/licenses_golden/excluded_files
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,7 @@
../../../fuchsia/sdk/linux/pkg/async_patterns_cpp/meta.json
../../../fuchsia/sdk/linux/pkg/async_patterns_testing_cpp/include/lib/async_patterns/testing
../../../fuchsia/sdk/linux/pkg/async_patterns_testing_cpp/meta.json
../../../fuchsia/sdk/linux/pkg/backend_fuchsia_globals/meta.json
../../../fuchsia/sdk/linux/pkg/component_incoming_cpp/meta.json
../../../fuchsia/sdk/linux/pkg/component_outgoing_cpp/meta.json
../../../fuchsia/sdk/linux/pkg/driver_component_cpp/meta.json
Expand Down
Loading

0 comments on commit 28ae9e3

Please sign in to comment.