[Impeller] remove compute tessellator. (flutter#52584)

We don't have any plans to use this in the near term. The algorithm works but can easily run out of memory, and would need to be entirely reworked to manage memory allocations.
a-siva · May 6, 2024 · 4cb9e02 · 4cb9e02
1 parent 422f92b
commit 4cb9e02
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 1,139 deletions.
diff --git a/ci/licenses_golden/excluded_files b/ci/licenses_golden/excluded_files
@@ -184,7 +184,6 @@
 ../../../flutter/impeller/renderer/backend/vulkan/test
 ../../../flutter/impeller/renderer/blit_pass_unittests.cc
 ../../../flutter/impeller/renderer/capabilities_unittests.cc
-../../../flutter/impeller/renderer/compute_subgroup_unittests.cc
 ../../../flutter/impeller/renderer/compute_unittests.cc
 ../../../flutter/impeller/renderer/device_buffer_unittests.cc
 ../../../flutter/impeller/renderer/pipeline_descriptor_unittests.cc

diff --git a/ci/licenses_golden/licenses_flutter b/ci/licenses_golden/licenses_flutter
@@ -40777,11 +40777,8 @@ ORIGIN: ../../../flutter/impeller/renderer/compute_pipeline_builder.cc + ../../.
 ORIGIN: ../../../flutter/impeller/renderer/compute_pipeline_builder.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/compute_pipeline_descriptor.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/compute_pipeline_descriptor.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/compute_tessellator.cc + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/compute_tessellator.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/context.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/context.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/path_polyline.comp + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/pipeline.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/pipeline.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/pipeline_builder.cc + ../../../flutter/LICENSE
@@ -40809,7 +40806,6 @@ ORIGIN: ../../../flutter/impeller/renderer/shader_library.h + ../../../flutter/L
 ORIGIN: ../../../flutter/impeller/renderer/shader_stage_compatibility_checker.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/snapshot.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/snapshot.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/stroke.comp + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/surface.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/surface.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/texture_mipmap.cc + ../../../flutter/LICENSE
@@ -43657,11 +43653,8 @@ FILE: ../../../flutter/impeller/renderer/compute_pipeline_builder.cc
 FILE: ../../../flutter/impeller/renderer/compute_pipeline_builder.h
 FILE: ../../../flutter/impeller/renderer/compute_pipeline_descriptor.cc
 FILE: ../../../flutter/impeller/renderer/compute_pipeline_descriptor.h
-FILE: ../../../flutter/impeller/renderer/compute_tessellator.cc
-FILE: ../../../flutter/impeller/renderer/compute_tessellator.h
 FILE: ../../../flutter/impeller/renderer/context.cc
 FILE: ../../../flutter/impeller/renderer/context.h
-FILE: ../../../flutter/impeller/renderer/path_polyline.comp
 FILE: ../../../flutter/impeller/renderer/pipeline.cc
 FILE: ../../../flutter/impeller/renderer/pipeline.h
 FILE: ../../../flutter/impeller/renderer/pipeline_builder.cc
@@ -43689,7 +43682,6 @@ FILE: ../../../flutter/impeller/renderer/shader_library.h
 FILE: ../../../flutter/impeller/renderer/shader_stage_compatibility_checker.h
 FILE: ../../../flutter/impeller/renderer/snapshot.cc
 FILE: ../../../flutter/impeller/renderer/snapshot.h
-FILE: ../../../flutter/impeller/renderer/stroke.comp
 FILE: ../../../flutter/impeller/renderer/surface.cc
 FILE: ../../../flutter/impeller/renderer/surface.h
 FILE: ../../../flutter/impeller/renderer/texture_mipmap.cc

diff --git a/impeller/BUILD.gn b/impeller/BUILD.gn
@@ -113,10 +113,6 @@ impeller_component("impeller_unittests") {
       "//third_party/vulkan_validation_layers:vulkan_gen_json_files",
     ]
   }
-
-  if (impeller_enable_compute) {
-    deps += [ "renderer:compute_tessellation_unittests" ]
-  }
 }
 
 if (impeller_supports_rendering) {

diff --git a/impeller/entity/contents/solid_color_contents.h b/impeller/entity/contents/solid_color_contents.h
@@ -14,10 +14,6 @@
 
 namespace impeller {
 
-class Path;
-class HostBuffer;
-struct VertexBuffer;
-
 class SolidColorContents final : public ColorSourceContents {
  public:
   SolidColorContents();

diff --git a/impeller/geometry/gradient.h b/impeller/geometry/gradient.h
@@ -6,12 +6,9 @@
 #define FLUTTER_IMPELLER_GEOMETRY_GRADIENT_H_
 
 #include <cstdint>
-#include <memory>
 #include <vector>
 
 #include "impeller/geometry/color.h"
-#include "impeller/geometry/path.h"
-#include "impeller/geometry/point.h"
 
 namespace impeller {
 

diff --git a/impeller/renderer/BUILD.gn b/impeller/renderer/BUILD.gn
@@ -20,27 +20,10 @@ if (impeller_enable_compute) {
     }
 
     shaders = [
-      "stroke.comp",
-      "path_polyline.comp",
       "prefix_sum_test.comp",
       "threadgroup_sizing_test.comp",
     ]
   }
-
-  impeller_component("compute_tessellation_unittests") {
-    testonly = true
-    sources = [ "compute_subgroup_unittests.cc" ]
-
-    deps = [
-      ":compute_shaders",
-      ":renderer",
-      "../display_list:skia_conversions",
-      "../entity",
-      "../fixtures",
-      "../playground:playground_test",
-      "//flutter/testing:testing_lib",
-    ]
-  }
 }
 
 impeller_component("renderer") {
@@ -109,10 +92,6 @@ impeller_component("renderer") {
   ]
 
   if (impeller_enable_compute) {
-    sources += [
-      "compute_tessellator.cc",
-      "compute_tessellator.h",
-    ]
     public_deps += [ ":compute_shaders" ]
   }