Validate if metric name in aggregations is unique. (Graylog2#16097)

* Validate if metric name in aggregations is unique. * Adding changelog. * Fixing problem when name is empty
a137872798 · Aug 8, 2023 · 0a8be6c · 0a8be6c
1 parent 8181238
commit 0a8be6c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/changelog/unreleased/issue-11592.toml b/changelog/unreleased/issue-11592.toml
@@ -0,0 +1,6 @@
+type = "fixed"
+message = "Validate in aggregation builder if metric name is unique."
+
+issues = ["11592"]
+pulls = ["16097"]
+
diff --git a/graylog2-web-interface/src/views/components/aggregationwizard/metric/MetricElement.ts b/graylog2-web-interface/src/views/components/aggregationwizard/metric/MetricElement.ts
@@ -28,6 +28,7 @@ type MetricError = {
   function?: string,
   field?: string,
   percentile?: string,
+  name?: string,
 };
 
 const hasErrors = <T extends {}> (errors: Array<T>): boolean => errors.filter((error) => Object.keys(error).length > 0).length > 0;
@@ -56,6 +57,10 @@ const validateMetrics = (values: WidgetConfigFormValues) => {
       metricError.percentile = 'Percentile is required.';
     }
 
+    if (metric.name && values.metrics.filter(({ name }) => name === metric.name).length > 1) {
+      metricError.name = 'Name must be unique.';
+    }
+
     return metricError;
   });