Skip to content

Commit

Permalink
Fix the waiting on EIP number label again (ethereum#5448)
Browse files Browse the repository at this point in the history
* Fix the waiting on EIP number label again

* Add extra check

Make sure that the EIP property exists

* Wait... if we want no label on false then this works!
  • Loading branch information
Pandapip1 authored Aug 12, 2022
1 parent 4487b43 commit d7d3c72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/.jekyll-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type: Informational": this?.new?.type == "Informational"
"type: Meta": this?.new?.type == "Meta"
"type: EIP1 (Process)": this?.old?.status == "Living" || this?.old?.eip == "<to be assigned>"
"waiting: EIP number": "!(this?.new?.eip > 0)"
"waiting: EIP number": isNaN(this?.new?.eip)
"classification: new EIP": this?.new?.eip && !this?.old?.eip
"classification: update EIP": this?.new?.eip && this?.old?.eip && this?.new?.status == this?.old?.status
"classification: EIP status change": this?.new?.eip && this?.old?.eip && this?.new?.status != this?.old?.status

0 comments on commit d7d3c72

Please sign in to comment.