Html Example - Update README accordingly #17
Conversation
| //see N. Zakas for fallback: | ||
| //https://github.com/nzakas/computer-science-in-javascript/tree/master/encodings/base64 | ||
| var base64 = "data:" + image.format + ";base64," + Base64.encodeBytes(image.data); | ||
| $('#title').text(tags.title); |
There was a problem hiding this comment.
I believe you can get rid of the jQuery dependency by using document.getElementById(id) instead of $('#id').
No need to add jQuery to the project if not really needed :-)
|
done :) |
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | ||
| <meta name="description" content=""> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <script src="id3-minimized.js" type="text/javascript"></script> |
There was a problem hiding this comment.
Didn't notice that this was an extra duplicate file, you should just point to ../dist/id3-minimized.js
There was a problem hiding this comment.
Done :)
Roland CIVET
+32(0)497/03 25 80
On 16/07/13 05:17, António Afonso wrote:
In example/index.html:
@@ -0,0 +1,42 @@
+
+
+
- <title>Javascript ID3 Reader</title>
- <script src="id3-minimized.js" type="text/javascript"></script>
Didn't notice that this was an extra duplicate file, you should just
point to |../dist/id3-minimized.js|—
Reply to this email directly or view it on GitHub
https://github.com/aadsm/JavaScript-ID3-Reader/pull/17/files#r5207765.
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | ||
| <meta name="description" content=""> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <script src="../dist/id3-minimized.js" type="text/javascript"></script> |
There was a problem hiding this comment.
Thanks but you still need to remove the example/id3-minized.js file then, so that I can merge the pull request :-)
There was a problem hiding this comment.
Done, you can merge
Still sorry for that.
Roland CIVET
+32(0)497/03 25 80
On 17/07/13 04:51, António Afonso wrote:
In example/index.html:
@@ -0,0 +1,42 @@
+
+
+
- <title>Javascript ID3 Reader</title>
- <script src="../dist/id3-minimized.js" type="text/javascript"></script>
Thanks but you still need to remove the |example/id3-minized.js| file
then, so that I can merge the pull request :-)—
Reply to this email directly or view it on GitHub
https://github.com/aadsm/JavaScript-ID3-Reader/pull/17/files#r5233856.
|
I squashed this pull request into one commit and added an example with the FileAPI |
|
Thank you very much for your pull request, it was definitely missing! |
I added an example that demonstrate how to get ID3 for title, artist and picture.
Readme updated accordingly