Replaced document.write call that adds VBScript with a document.appendChild call due to the document.write call failing when script is loaded asynchronously

[mrand01]

Just as the title says. The document.write call that adds the VBScript (presumably for very old IE versions) fails when id3-minimized.js is loaded asynchronously (like in a requirejs project, or similar). I modified this code to instead use document.appendChild. All seems well now.

[aadsm]

Cool! Thank you.
Can you please amend all these commits into a single one? :-) After you amend you can just force push into your branch and it will automatically update this PR.

[mrand01]

I have to admit, I'm a complete git/github noob and have no idea how to go about doing this. I understand why it'd be beneficial though. How would I go about amending all the commits into a single commit?

[aadsm]

Ah, no worries, I can do it on my side.

If you're interested in learning more about it here it is: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
If you're not that familiar with git it can be a bit scary at first to be honest.

There's also a lot of good information on github help about git and github itself: https://help.github.com/articles/what-are-other-good-resources-for-learning-git-and-github

[mrand01]

Yep, reading up on rebasing now. I've been an SVN junkie for the last 10
years, and unfortunately still am professionally. I've been trying to mess
around w/ Git more on the side, just tough to find the time.

On Mon, Apr 21, 2014 at 1:13 PM, António Afonso [email protected]:

Ah, no worries, I can do it on my side.

If you're interested in learning more about it here it is:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
If you're not that familiar with git it can be a bit scary at first to be
honest.

There's also a lot of good information on github help about git and github
itself:
https://help.github.com/articles/what-are-other-good-resources-for-learning-git-and-github

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-40953680
.

[mrand01]

Eh, I just tried and I think I messed something up. Going to leave it
alone and see what you come up with. You're right, this stuff can get
tricky for noobs!

On Mon, Apr 21, 2014 at 1:15 PM, Michael Randolph [email protected] wrote:

Yep, reading up on rebasing now. I've been an SVN junkie for the last 10
years, and unfortunately still am professionally. I've been trying to mess
around w/ Git more on the side, just tough to find the time.

On Mon, Apr 21, 2014 at 1:13 PM, António Afonso [email protected]:

Ah, no worries, I can do it on my side.

If you're interested in learning more about it here it is:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
If you're not that familiar with git it can be a bit scary at first to be
honest.

There's also a lot of good information on github help about git and
github itself:
https://help.github.com/articles/what-are-other-good-resources-for-learning-git-and-github

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-40953680
.

[aadsm]

It's ok, the first commit is the one that matters :-)
I've just changed the commit message and recompiled using the version of closure I've been using. I've found that some older versions have bugs and I don't know which version you used.

4ed3614

Thank you very much for this!