Skip to content

Commit

Permalink
fix: allow custom actions to run in azure functions (microsoft#3294)
Browse files Browse the repository at this point in the history
Updates SDK packages to 4.9.3

Co-authored-by: Chris Whitten <[email protected]>
  • Loading branch information
luhan2017 and cwhitten authored Jun 3, 2020
1 parent 9937122 commit 863d738
Show file tree
Hide file tree
Showing 6 changed files with 50 additions and 38 deletions.
6 changes: 6 additions & 0 deletions runtime/dotnet/ComposerRuntime.sln
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.BotFramework.Comp
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.BotFramework.Composer.Functions", "azurefunctions\Microsoft.BotFramework.Composer.Functions.csproj", "{9FC308C1-F0EC-41BE-90FD-9DC00DA7B80B}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.BotFramework.Composer.CustomAction", "customaction\Microsoft.BotFramework.Composer.CustomAction.csproj", "{EE58DDD7-DE91-4DB0-A6C6-D8182523896B}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand All @@ -33,6 +35,10 @@ Global
{9FC308C1-F0EC-41BE-90FD-9DC00DA7B80B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9FC308C1-F0EC-41BE-90FD-9DC00DA7B80B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{9FC308C1-F0EC-41BE-90FD-9DC00DA7B80B}.Release|Any CPU.Build.0 = Release|Any CPU
{EE58DDD7-DE91-4DB0-A6C6-D8182523896B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{EE58DDD7-DE91-4DB0-A6C6-D8182523896B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{EE58DDD7-DE91-4DB0-A6C6-D8182523896B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{EE58DDD7-DE91-4DB0-A6C6-D8182523896B}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework>
<TargetFramework>netcoreapp3.1</TargetFramework>
<AzureFunctionsVersion>v3</AzureFunctionsVersion>
<UserSecretsId>2eb1c70c-5cd2-4c08-8aab-df989c347067</UserSecretsId>
</PropertyGroup>
Expand All @@ -12,19 +12,20 @@
<CodeAnalysisRuleSet>..\core\Microsoft.BotFramework.Composer.Core.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.1.2" />
<PackageReference Include="Microsoft.Azure.Functions.Extensions" Version="1.0.0" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.2-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.3-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.3" />
<PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="3.1.3" />
<PackageReference Include="Microsoft.Extensions.Http" Version="3.1.3" />
<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="3.0.3" />
Expand Down
5 changes: 5 additions & 0 deletions runtime/dotnet/azurefunctions/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
using Microsoft.Bot.Connector.Authentication;
using Microsoft.BotFramework.Composer.Core;
using Microsoft.BotFramework.Composer.Core.Settings;

//using Microsoft.BotFramework.Composer.CustomAction;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using System;
Expand Down Expand Up @@ -96,6 +98,9 @@ public override void Configure(IFunctionsHostBuilder builder)
ComponentRegistration.Add(new QnAMakerComponentRegistration());
ComponentRegistration.Add(new LuisComponentRegistration());

// This is for custom action component registration.
//ComponentRegistration.Add(new CustomActionComponentRegistration());

// Register the skills client and skills request handler.
services.AddSingleton<SkillConversationIdFactoryBase, SkillConversationIdFactory>();
services.AddHttpClient<BotFrameworkClient, SkillHttpClient>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.1.2" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.2-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.3-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.3" />
<PackageReference Include="MSTest.TestFramework" Version="1.4.0" />
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.66">
<PrivateAssets>all</PrivateAssets>
Expand Down
24 changes: 12 additions & 12 deletions runtime/dotnet/core/Microsoft.BotFramework.Composer.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.2-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.Luis" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.AI.QnA" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.ApplicationInsights" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Azure" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Debugging" Version="4.9.3-preview" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="4.9.3" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.9.3" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.2" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="4.9.3" />
</ItemGroup>

</Project>

0 comments on commit 863d738

Please sign in to comment.