2.8.2 - fix craftcms#153

aaronbushnell · Sep 3, 2021 · fb92fef · fb92fef
1 parent 0cb1f43
commit fb92fef
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Release Notes for Element API
 
+## 2.8.2 - 2021-09-03
+
+### Fixed
+- Fixed a bug where custom `cache` durations were getting ignored. ([#153](https://github.com/craftcms/element-api/issues/153))
+
 ## 2.8.1 - 2021-09-01
 
 ### Fixed

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "craftcms/element-api",
   "description": "Create a JSON API for your elements in Craft",
-  "version": "2.8.1",
+  "version": "2.8.2",
   "type": "craft-plugin",
   "keywords": [
     "api",

diff --git a/src/controllers/DefaultController.php b/src/controllers/DefaultController.php
@@ -88,10 +88,11 @@ public function actionIndex(string $pattern): Response
             $this->response->getHeaders()->setDefault('X-Robots-Tag', 'none');
 
             // Before anything else, check the cache
-            $cache = (
-                ArrayHelper::remove($config, 'cache', true) &&
-                !($this->request->getIsPreview() || $this->request->getIsLivePreview())
-            );
+            if (!($this->request->getIsPreview() || $this->request->getIsLivePreview())) {
+                $cache = ArrayHelper::remove($config, 'cache', true);
+            } else {
+                $cache = false;
+            }
 
             $cacheKey = ArrayHelper::remove($config, 'cacheKey')
                 ?? implode(':', [