Fix: Provide refactoring for IndexedDBShim (issue #87).

aaronpowell · Apr 11, 2016 · d40286f · d40286f
1 parent 79fe048
commit d40286f
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 11 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -41,6 +41,7 @@
     an `add()`
 - Fix: Avoid adding `keyPath` property to `add`/`update` records if property
     is already present;
+- Fix: Provide refactoring for IndexedDBShim (issue #87).
 - Validation: Tighter checking on argument to `modify` method (ensure is
     an object) and on index creation objects (issue #149)
 - Docs: Badges, CHANGES, clarify `add`, `update`, `delete`, `filter` and

diff --git a/dist/db.js b/dist/db.js
@@ -747,7 +747,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
         return err;
     };
 
-    var createSchema = function createSchema(e, schema, db, server, version) {
+    var createSchema = function createSchema(e, request, schema, db, server, version) {
         if (!schema || schema.length === 0) {
             return;
         }
@@ -762,7 +762,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
                 //      should be without risk in this loop
                 // `NotFoundError` - since we are iterating the dynamically updated
                 //      `objectStoreNames`
-                e.currentTarget.transaction.db.deleteObjectStore(name);
+                db.deleteObjectStore(name);
             }
         }
 
@@ -771,7 +771,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
             var table = schema[tableName];
             var store = void 0;
             if (db.objectStoreNames.contains(tableName)) {
-                store = e.currentTarget.transaction.objectStore(tableName); // Shouldn't throw
+                store = request.transaction.objectStore(tableName); // Shouldn't throw
             } else {
                     // Errors for which we are not concerned and why:
                     // `InvalidStateError` - We are in the upgrade transaction.
@@ -874,7 +874,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
                             reject(e);
                         };
                         request.onupgradeneeded = function (e) {
-                            var err = createSchema(e, schema, e.target.result, server, version);
+                            var err = createSchema(e, request, schema, e.target.result, server, version);
                             if (err) {
                                 reject(err);
                             }

diff --git a/dist/db.js.map b/dist/db.js.map
diff --git a/dist/db.min.js b/dist/db.min.js
diff --git a/dist/db.min.js.map b/dist/db.min.js.map
diff --git a/src/db.js b/src/db.js
@@ -655,7 +655,7 @@
         return err;
     };
 
-    const createSchema = function (e, schema, db, server, version) {
+    const createSchema = function (e, request, schema, db, server, version) {
         if (!schema || schema.length === 0) {
             return;
         }
@@ -670,7 +670,7 @@
                 //      should be without risk in this loop
                 // `NotFoundError` - since we are iterating the dynamically updated
                 //      `objectStoreNames`
-                e.currentTarget.transaction.db.deleteObjectStore(name);
+                db.deleteObjectStore(name);
             }
         }
 
@@ -679,7 +679,7 @@
             const table = schema[tableName];
             let store;
             if (db.objectStoreNames.contains(tableName)) {
-                store = e.currentTarget.transaction.objectStore(tableName); // Shouldn't throw
+                store = request.transaction.objectStore(tableName); // Shouldn't throw
             } else {
                 // Errors for which we are not concerned and why:
                 // `InvalidStateError` - We are in the upgrade transaction.
@@ -778,7 +778,7 @@
                         reject(e);
                     };
                     request.onupgradeneeded = e => {
-                        let err = createSchema(e, schema, e.target.result, server, version);
+                        let err = createSchema(e, request, schema, e.target.result, server, version);
                         if (err) {
                             reject(err);
                         }