The options.reason parameter within the onQuestionAdded event returns…

… undefined when a question is dropped from a Toolbox fixed surveyjs#4381 (surveyjs#4387)
aaronrau · Jul 28, 2023 · be779dc · be779dc
1 parent e1f55b7
commit be779dc
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/survey-creator-core/src/components/toolbox/toolbox-tool.ts b/packages/survey-creator-core/src/components/toolbox/toolbox-tool.ts
@@ -29,10 +29,12 @@ export class ToolboxToolViewModel extends Base {
     this._node = pointerDownEvent.currentTarget;
     this._node.classList.add("svc-toolbox__tool--pressed");
     document.addEventListener("pointerup", this.onPointerUp);
+    this.creator.onDragDropItemStart();
   }
 
   private _node: any
   private onPointerUp = (pointerUpEvent) => {
+    this.creator.onDragDropItemEnd();
     this._node.classList.remove("svc-toolbox__tool--pressed");
     this._node = null;
     document.removeEventListener("pointerup", this.onPointerUp);

diff --git a/packages/survey-creator-core/src/creator-base.ts b/packages/survey-creator-core/src/creator-base.ts
@@ -1934,6 +1934,12 @@ export class CreatorBase extends Base
   }
 
   private addNewElementReason: string;
+  public onDragDropItemStart(): void {
+    this.addNewElementReason = "DROPPED_FROM_TOOLBOX";
+  }
+  public onDragDropItemEnd(): void {
+    this.addNewElementReason = undefined;
+  }
   @ignoreUndoRedo()
   private doOnQuestionAdded(question: Question, parentPanel: any) {
     question.name = this.generateUniqueName(question, question.name);

diff --git a/packages/survey-creator-core/tests/creator-base.tests.ts b/packages/survey-creator-core/tests/creator-base.tests.ts
@@ -36,7 +36,7 @@ import { TabJsonEditorTextareaPlugin } from "../src/components/tabs/json-editor-
 import { TabJsonEditorAcePlugin } from "../src/components/tabs/json-editor-ace";
 import { isTextInput } from "../src/creator-base";
 import { ItemValueWrapperViewModel } from "../src/components/item-value";
-import { getNextItemText } from "../src/utils/utils";
+import { ToolboxToolViewModel } from "../src/components/toolbox/toolbox-tool";
 
 import {
   getElementWrapperComponentData,
@@ -3741,6 +3741,16 @@ test("Reason of question Added from toolbox, onclicking add question button, on
   expect(reason[3]).toEqual("ELEMENT_COPIED");
   expect(reason[4]).toEqual("ELEMENT_COPIED");
   expect(reason[5]).toEqual("ELEMENT_COPIED");
+
+  const toolboxViwer = new ToolboxToolViewModel(creator.toolbox.items[0], creator);
+  toolboxViwer.click({});
+  expect(reason).toHaveLength(7);
+  expect(reason[6]).toEqual("ADDED_FROM_TOOLBOX");
+  creator.onDragDropItemStart();
+  creator.survey.pages[0].addNewQuestion("text", "qqq1");
+  creator.onDragDropItemEnd();
+  expect(reason).toHaveLength(8);
+  expect(reason[7]).toEqual("DROPPED_FROM_TOOLBOX");
 });
 test("Initial Property Grid category expanded state", (): any => {
   const creator = new CreatorTester();