No need to configure production OAuth app on release anymore

aawaheed · Feb 18, 2020 · c32bcee · c32bcee
1 parent 72bde68
commit c32bcee
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml
@@ -25,8 +25,6 @@ jobs:
           version: latest
           args: release --release-notes=CHANGELOG.md
         env:
-          GH_OAUTH_CLIENT_ID: 178c6fc778ccc68e1d6a
-          GH_OAUTH_CLIENT_SECRET: ${{secrets.OAUTH_CLIENT_SECRET}}
           GITHUB_TOKEN: ${{secrets.UPLOAD_GITHUB_TOKEN}}
   msi:
     needs: goreleaser

diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -13,8 +13,6 @@ builds:
       main: ./cmd/gh
       ldflags:
         - -s -w -X github.com/cli/cli/command.Version={{.Version}} -X github.com/cli/cli/command.BuildDate={{time "2006-01-02"}}
-        - -X github.com/cli/cli/context.oauthClientID={{.Env.GH_OAUTH_CLIENT_ID}}
-        - -X github.com/cli/cli/context.oauthClientSecret={{.Env.GH_OAUTH_CLIENT_SECRET}}
         - -X main.updaterEnabled=cli/cli
     id: macos
     goos: [darwin]