completed DN comparison, added special handling for serial numbers

aaxx · Apr 8, 2019 · 4ec02c7 · 4ec02c7
1 parent 02d0a89
commit 4ec02c7
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -24,4 +24,5 @@ pkix/out
 prov/out
 tls/out
 test/out
+codesigning.jks
 
diff --git a/prov/src/main/java/org/bouncycastle/jce/provider/PKIXNameConstraintValidator.java b/prov/src/main/java/org/bouncycastle/jce/provider/PKIXNameConstraintValidator.java
@@ -8,10 +8,13 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.bouncycastle.asn1.ASN1ObjectIdentifier;
 import org.bouncycastle.asn1.ASN1OctetString;
 import org.bouncycastle.asn1.ASN1Sequence;
 import org.bouncycastle.asn1.DERIA5String;
 import org.bouncycastle.asn1.x500.RDN;
+import org.bouncycastle.asn1.x500.X500Name;
+import org.bouncycastle.asn1.x500.style.BCStyle;
 import org.bouncycastle.asn1.x500.style.IETFUtils;
 import org.bouncycastle.asn1.x500.style.RFC4519Style;
 import org.bouncycastle.asn1.x509.GeneralName;
@@ -64,13 +67,28 @@ private static boolean withinDNSubtree(
         {
             // both subtree and dns are a ASN.1 Name and the elements are a RDN
             RDN subtreeRdn = RDN.getInstance(subtree.getObjectAt(j));
+            dnsiteration:
             for (int k=0; k<dns.size(); k++) {
                 RDN dnsRdn = RDN.getInstance(dns.getObjectAt(k));
-                // type must match, other types which are not restricted are allowed, see https://tools.ietf.org/html/rfc5280#section-7.1
-                if (subtreeRdn.getFirst().getType().equals(dnsRdn.getFirst().getType())) {
+                // check if types and values of all naming attributes are matching, other types which are not restricted are allowed, see https://tools.ietf.org/html/rfc5280#section-7.1
+                if (subtreeRdn.size() > 0 && subtreeRdn.size() == dnsRdn.size()) {
+                    // Two relative distinguished names
+                    //   RDN1 and RDN2 match if they have the same number of naming attributes
+                    //   and for each naming attribute in RDN1 there is a matching naming attribute in RDN2.
+                    //   NOTE: this is checking the attributes in the same order, which might be not necessary, if this is a problem also IETFUtils.rDNAreEqual mus tbe changed.
+                    for (int l=0; l<subtreeRdn.size(); l++) {
+                        if (!subtreeRdn.getTypesAndValues()[l].getType().equals(dnsRdn.getTypesAndValues()[l].getType())) {
+                            continue dnsiteration;
+                        }
+                    }
                     // use new RFC 5280 comparison, NOTE: this is not different from with RFC 3280, where only binary comparison is used
                     // obey RFC 5280 7.1
-                    if (!IETFUtils.rDNAreEqual(subtreeRdn, dnsRdn)) {
+                    // special treatment of serialNumber for GSMA SGP.22 RSP specification
+                    if (subtreeRdn.size() == 1 && subtreeRdn.getFirst().getType().equals(RFC4519Style.serialNumber)) {
+                        if (!dnsRdn.getFirst().getValue().toString().startsWith(subtreeRdn.getFirst().getValue().toString())) {
+                            return false;
+                        }
+                    } else if (!IETFUtils.rDNAreEqual(subtreeRdn, dnsRdn)) {
                         return false;
                     }
                 }

diff --git a/prov/src/test/java/org/bouncycastle/jce/provider/test/PKIXNameConstraintsTest.java b/prov/src/test/java/org/bouncycastle/jce/provider/test/PKIXNameConstraintsTest.java
@@ -85,12 +85,12 @@ public class PKIXNameConstraintsTest
 
     private final static String testDNIsConstraint[] =
     { "O=test org, OU=test org unit",
-            "O=test org, OU=test org unit, CN=John Doe" };
+            "O=test org, OU=test org unit, CN=John Doe",
+            "OU=test org unit, O=test org, CN=John Doe",};
 
     private final static String testDNIsNotConstraint[] =
     { "O=test org, OU=test org unit, CN=John Doe2",
             "O=test org, OU=test org unit2",
-            "OU=test org unit, O=test org, CN=John Doe",
             "O=test org, OU=test org unit, CN=John Doe, L=USA" };
 
     private final static String testDNS = "abc.test.com";