MDL-43656 mod_feedback: availablity date logic incorrect

abgreeve · Mar 3, 2014 · 1298acc · 1298acc
1 parent dc8f55c
commit 1298acc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/mod/feedback/complete.php b/mod/feedback/complete.php
@@ -176,8 +176,8 @@
 
 //check, if the feedback is open (timeopen, timeclose)
 $checktime = time();
-$feedback_is_closed = ($feedback->timeopen > $checktime) OR
-                      ($feedback->timeclose < $checktime AND
+$feedback_is_closed = ($feedback->timeopen > $checktime) ||
+                      ($feedback->timeclose < $checktime &&
                             $feedback->timeclose > 0);
 
 if ($feedback_is_closed) {

diff --git a/mod/feedback/complete_guest.php b/mod/feedback/complete_guest.php
@@ -177,8 +177,8 @@
 //check, if the feedback is open (timeopen, timeclose)
 $checktime = time();
 
-$feedback_is_closed = ($feedback->timeopen > $checktime) OR
-                      ($feedback->timeclose < $checktime AND
+$feedback_is_closed = ($feedback->timeopen > $checktime) ||
+                      ($feedback->timeclose < $checktime &&
                             $feedback->timeclose > 0);
 
 if ($feedback_is_closed) {