MDL-12789 - dont unnecessarily iterate over all groups

abgreeve · Jan 1, 2008 · 25c3f91 · 25c3f91
1 parent e9c0fa3
commit 25c3f91
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/enrol/manual/enrol.php b/enrol/manual/enrol.php
@@ -188,15 +188,16 @@ function check_entry($form, $course) {
 * @param    password  the submitted enrolment key
 */
 function check_group_entry ($courseid, $password) {
-    $ingroup = false;
-    if (($groups = groups_get_all_groups($courseid))) {
+
+    if ($groups = groups_get_all_groups($courseid)) {
         foreach ($groups as $group) {
             if ( !empty($group->enrolmentkey) and (stripslashes($password) == $group->enrolmentkey) ) {
-                $ingroup = $group->id;
+                return $group->id;
             }
         }
     }
-    return $ingroup;
+
+    return false;
 }