Skip to content

Commit

Permalink
MDL-83332 core: Remove slasharguments config modification lines
Browse files Browse the repository at this point in the history
MDL-62640 removed the 'slasharguments' config, and 3229dda attempted to
restore it by setting it to 1. This could unintentionally reset the
'slasharguments' config for all sites upgrading to 4.5.
  • Loading branch information
rezaies committed Oct 2, 2024
1 parent 83526c7 commit 6399179
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions lib/db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -1421,14 +1421,6 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2024092000.01);
}

if ($oldversion < 2024092400.01) {
// The slasharguments setting has been removed.
unset_config('slasharguments');

// Main savepoint reached.
upgrade_main_savepoint(true, 2024092400.01);
}

if ($oldversion < 2024092600.00) {
// If h5plib_v126 is no longer present, remove it.
if (!file_exists($CFG->dirroot . '/h5p/h5plib/v126/version.php')) {
Expand All @@ -1445,13 +1437,5 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2024092600.00);
}

if ($oldversion < 2024100100.01) {
// Set the slasharguments to 1 as default.
set_config('slasharguments', 1);

// Main savepoint reached.
upgrade_main_savepoint(true, 2024100100.01);
}

return true;
}

0 comments on commit 6399179

Please sign in to comment.