MDL-74333 badges: Check profile criteria valid when reviewing

abgreeve · May 4, 2022 · a0f47c8 · a0f47c8
1 parent 9478dc6
commit a0f47c8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/badges/criteria/award_criteria_profile.php b/badges/criteria/award_criteria_profile.php
@@ -202,8 +202,8 @@ public function review($userid, $filtered = false) {
                 $join .= " LEFT JOIN {user_info_data} uid{$idx} ON uid{$idx}.userid = u.id AND uid{$idx}.fieldid = :fieldid{$idx} ";
                 $sqlparams["fieldid{$idx}"] = $param['field'];
                 $whereparts[] = "uid{$idx}.id IS NOT NULL";
-            } else {
-                // This is a field from {user} table.
+            } else if (in_array($param['field'], $this->allowed_default_fields)) {
+                // This is a valid field from {user} table.
                 if ($param['field'] == 'picture') {
                     // The picture field is numeric and requires special handling.
                     $whereparts[] = "u.{$param['field']} != 0";