Skip to content

Commit

Permalink
MDL-45044 filter_tex: properly escape excutable pathnames for Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
@dthies
dthies committed Jul 24, 2014
1 parent 40f0ad2 commit a275c52
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 17 deletions.
15 changes: 8 additions & 7 deletions filter/tex/latex.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ function render( $formula, $filename, $fontsize=12, $density=240, $background=''
if (empty($pathlatex)) {
return false;
}
$pathlatex = escapeshellarg(trim($pathlatex, " '\""));

$doc = $this->construct_latex_document( $formula, $fontsize );

Expand All @@ -114,15 +115,15 @@ function render( $formula, $filename, $fontsize=12, $density=240, $background=''
fclose( $fh );

// run latex on document
$command = "{$pathlatex} --interaction=nonstopmode --halt-on-error $tex";
$command = "$pathlatex --interaction=nonstopmode --halt-on-error $tex";
chdir( $this->temp_dir );
if ($this->execute($command, $log)) { // It allways False on Windows
// return false;
}

// run dvips (.dvi to .ps)
$pathdvips = get_config('filter_tex', 'pathdvips');
$command = "{$pathdvips} -E $dvi -o $ps";
$pathdvips = escapeshellarg(trim(get_config('filter_tex', 'pathdvips'), " '\""));
$command = "$pathdvips -E $dvi -o $ps";
if ($this->execute($command, $log )) {
return false;
}
Expand All @@ -134,11 +135,11 @@ function render( $formula, $filename, $fontsize=12, $density=240, $background=''
$bg_opt = "";
}
if ($convertformat == 'svg') {
$pathdvisvgm = get_config('filter_tex', 'pathdvisvgm');
$command = "{$pathdvisvgm} -E $ps -o $img";
$pathdvisvgm = escapeshellarg(trim(get_config('filter_tex', 'pathdvisvgm'), " '\""));
$command = "$pathdvisvgm -E $ps -o $img";
} else {
$pathconvert = get_config('filter_tex', 'pathconvert');
$command = "{$pathconvert} -density $density -trim $bg_opt $ps $img";
$pathconvert = escapeshellarg(trim(get_config('filter_tex', 'pathconvert'), " '\""));
$command = "$pathconvert -density $density -trim $bg_opt $ps $img";
}
if ($this->execute($command, $log )) {
return false;
Expand Down
7 changes: 4 additions & 3 deletions filter/tex/lib.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,10 @@ function filter_tex_updatedcallback($name) {
return;
}

$pathdvips = get_config('filter_tex', 'pathdvips');
$pathconvert = get_config('filter_tex', 'pathconvert');
$pathdvisvgm = get_config('filter_tex', 'pathdvisvgm');
$pathlatex = trim($pathlatex, " '\"");
$pathdvips = trim(get_config('filter_tex', 'pathdvips'), " '\"");
$pathconvert = trim(get_config('filter_tex', 'pathconvert'), " '\"");
$pathdvisvgm = trim(get_config('filter_tex', 'pathdvisvgm'), " '\"");

$supportedformats = array('gif');
if ((is_file($pathlatex) && is_executable($pathlatex)) &&
Expand Down
19 changes: 16 additions & 3 deletions filter/tex/settings.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,22 @@
} else if (PHP_OS=='WINNT' or PHP_OS=='WIN32' or PHP_OS=='Windows') {
// note: you need Ghostscript installed (standard), miktex (standard)
// and ImageMagick (install at c:\ImageMagick)
$default_filter_tex_pathlatex = "\"c:\\texmf\\miktex\\bin\\latex.exe\" ";
$default_filter_tex_pathdvips = "\"c:\\texmf\\miktex\\bin\\dvips.exe\" ";
$default_filter_tex_pathconvert = "\"c:\\imagemagick\\convert.exe\" ";
$default_filter_tex_pathlatex = "c:\\texmf\\miktex\\bin\\latex.exe";
$default_filter_tex_pathdvips = "c:\\texmf\\miktex\\bin\\dvips.exe";
$default_filter_tex_pathdvisvgm = "c:\\texmf\\miktex\\bin\\dvisvgm.exe";
$default_filter_tex_pathconvert = "c:\\imagemagick\\convert.exe";
}

$pathlatex = get_config('filter_tex', 'pathlatex');
$pathdvips = get_config('filter_tex', 'pathdvips');
$pathconvert = get_config('filter_tex', 'pathconvert');
$pathdvisvgm = get_config('filter_tex', 'pathdvisvgm');
if (strrpos($pathlatex . $pathdvips . $pathconvert . $pathdvisvgm, '"') or
strrpos($pathlatex . $pathdvips . $pathconvert . $pathdvisvgm, "'")) {
set_config('pathlatex', trim($pathlatex, " '\""), 'filter_tex');
set_config('pathdvips', trim($pathdvips, " '\""), 'filter_tex');
set_config('pathconvert', trim($pathconvert, " '\""), 'filter_tex');
set_config('pathdvisvgm', trim($pathdvisvgm, " '\""), 'filter_tex');
}

$items[] = new admin_setting_configexecutable('filter_tex/pathlatex', get_string('pathlatex', 'filter_tex'), '', $default_filter_tex_pathlatex);
Expand Down
12 changes: 8 additions & 4 deletions filter/tex/texdebug.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,28 +200,28 @@ function TexOutput($expression, $graphic=false) {
// first check if it is likely to work at all
$output .= "<h3>Checking executables</h3>\n";
$executablesexist = true;
$pathlatex = get_config('filter_tex', 'pathlatex');
$pathlatex = trim(get_config('filter_tex', 'pathlatex'), " '\"");
if (is_file($pathlatex)) {
$output .= "latex executable ($pathlatex) is readable<br />\n";
} else {
$executablesexist = false;
$output .= "<b>Error:</b> latex executable ($pathlatex) is not readable<br />\n";
}
$pathdvips = get_config('filter_tex', 'pathdvips');
$pathdvips = trim(get_config('filter_tex', 'pathdvips'), " '\"");
if (is_file($pathdvips)) {
$output .= "dvips executable ($pathdvips) is readable<br />\n";
} else {
$executablesexist = false;
$output .= "<b>Error:</b> dvips executable ($pathdvips) is not readable<br />\n";
}
$pathconvert = get_config('filter_tex', 'pathconvert');
$pathconvert = trim(get_config('filter_tex', 'pathconvert'), " '\"");
if (is_file($pathconvert)) {
$output .= "convert executable ($pathconvert) is readable<br />\n";
} else {
$executablesexist = false;
$output .= "<b>Error:</b> convert executable ($pathconvert) is not readable<br />\n";
}
$pathdvisvgm = get_config('filter_tex', 'pathdvisvgm');
$pathdvisvgm = trim(get_config('filter_tex', 'pathdvisvgm'), " '\"");
if (is_file($pathdvisvgm)) {
$output .= "dvisvgm executable ($pathdvisvgm) is readable<br />\n";
} else {
Expand Down Expand Up @@ -252,17 +252,21 @@ function TexOutput($expression, $graphic=false) {
chdir($latex->temp_dir);

// step 1: latex command
$pathlatex = escapeshellarg($pathlatex);
$cmd = "$pathlatex --interaction=nonstopmode --halt-on-error $tex";
$output .= execute($cmd);

// step 2: dvips command
$pathdvips = escapeshellarg($pathdvips);
$cmd = "$pathdvips -E $dvi -o $ps";
$output .= execute($cmd);

// Step 3: Set convert or dvisvgm command.
if ($convertformat == 'svg') {
$pathdvisvgm = escapeshellarg($pathdvisvgm);
$cmd = "$pathdvisvgm -E $ps -o $img";
} else {
$pathconvert = escapeshellarg($pathconvert);
$cmd = "$pathconvert -density 240 -trim $ps $img ";
}
$output .= execute($cmd);
Expand Down

0 comments on commit a275c52

Please sign in to comment.